Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH 4/4] drm/xe/oa: Stop whitelisting OAG registers after Xe3
Date: Wed,  7 Jan 2026 16:20:05 -0800	[thread overview]
Message-ID: <20260108002000.384449-10-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20260108002000.384449-6-matthew.d.roper@intel.com>

According to Xe2 and beyond's hardware design, userspace does not need
access to OAG_OAHEADPTR, OAG_OATAILPTR, OAG_OABUFFER, or
OAG_OASTARTTRIG_COUNTER; the hardware deliberately blocks userspace
access to these registers and adding them to our software whitelist was
a mistake.  However since they're already on the software list, it's
possible that userspace software has developed an unwanted dependency on
them and that removal of access now could break userspace.  So while we
investigate further to determine whether removal is safe or not, let's
add an upper bound to prevent the mistake from spreading further past
our current Xe3 platforms.

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_reg_whitelist.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c
index 99956c3574f9..5f8f78f0f1f5 100644
--- a/drivers/gpu/drm/xe/xe_reg_whitelist.c
+++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c
@@ -107,14 +107,14 @@ static const struct xe_rtp_entry_sr register_whitelist[] = {
 	WHITELIST_OA_MMIO_TRG(OAMERT_STATUS, OAMERT_HEAD_POINTER)
 
 	{ XE_RTP_NAME("oag_mmio_trg_rcs"),
-	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED),
+	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 3099),
 		       ENGINE_CLASS(RENDER)),
 	  XE_RTP_ACTIONS(WHITELIST(OAG_OAHEADPTR,
 				   RING_FORCE_TO_NONPRIV_ACCESS_RD |
 				   RING_FORCE_TO_NONPRIV_RANGE_4))
 	},
 	{ XE_RTP_NAME("oag_mmio_trg_ccs"),
-	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED),
+	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 3099),
 		       ENGINE_CLASS(COMPUTE)),
 	  XE_RTP_ACTIONS(WHITELIST(OAG_OAHEADPTR,
 				   RING_FORCE_TO_NONPRIV_ACCESS_RD |
-- 
2.52.0


  parent reply	other threads:[~2026-01-08  0:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  0:20 [PATCH 0/4] Start fixing OA whitelist mistakes Matt Roper
2026-01-08  0:20 ` [PATCH 1/4] drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2 Matt Roper
2026-01-08  0:20 ` [PATCH 2/4] drm/xe/oa: Stop whitelisting OAG_OASTATUS Matt Roper
2026-01-08  0:20 ` [PATCH 3/4] drm/xe/oa: Stop whitelisting OAM registers on non Xe2/Xe3 Matt Roper
2026-01-08  0:20 ` Matt Roper [this message]
2026-01-08  0:26 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes Patchwork
2026-01-08  0:27 ` ✓ CI.KUnit: success " Patchwork
2026-01-08  1:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-08  2:43 ` ✗ Xe.CI.Full: failure " Patchwork
2026-02-26 23:20 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes (rev2) Patchwork
2026-02-26 23:22 ` ✓ CI.KUnit: success " Patchwork
2026-02-27  0:45 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27  6:58 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108002000.384449-10-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox