From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH 3/4] drm/xe/oa: Stop whitelisting OAM registers on non Xe2/Xe3
Date: Wed, 7 Jan 2026 16:20:04 -0800 [thread overview]
Message-ID: <20260108002000.384449-9-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20260108002000.384449-6-matthew.d.roper@intel.com>
With the introduction of standalone media in Xe_LPM (version 13.00), the
OAM register space was part of the hardware's built-in register
whitelist, granting userspace read-only access automatically. There is
no need to explicitly whitelist the registers on media version 13.00.
From Xe2_HPM (13.01) onward, userspace access to these registers was
deliberately removed by the hardware teams; by design, those registers
are not supposed to be needed by userspace for proper OA operation and
they're not supposed to be added to the software whitelist either.
Unfortunately they're already on the software table, so it's possible
that some of our KMD<->UMD OA interaction got misdesigned and trying to
remove them now might break userspace. While we investigate further to
see whether or not it's possible to safely remove them, place an upper
bound on the whitelist entries to prevent this mistake from spreading
past Xe3 platforms.
Bspec: 45545, 60150
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/xe/xe_reg_whitelist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c
index 7491a8393b6f..99956c3574f9 100644
--- a/drivers/gpu/drm/xe/xe_reg_whitelist.c
+++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c
@@ -121,12 +121,12 @@ static const struct xe_rtp_entry_sr register_whitelist[] = {
RING_FORCE_TO_NONPRIV_RANGE_4))
},
{ XE_RTP_NAME("oam_mmio_trg_vcs"),
- XE_RTP_RULES(MEDIA_VERSION_RANGE(1300, XE_RTP_END_VERSION_UNDEFINED),
+ XE_RTP_RULES(MEDIA_VERSION_RANGE(1301, 3099),
ENGINE_CLASS(VIDEO_DECODE)),
XE_RTP_ACTIONS(WHITELIST_OAM_MMIO_TRG)
},
{ XE_RTP_NAME("oam_mmio_trg_vecs"),
- XE_RTP_RULES(MEDIA_VERSION_RANGE(1300, XE_RTP_END_VERSION_UNDEFINED),
+ XE_RTP_RULES(MEDIA_VERSION_RANGE(1301, 3099),
ENGINE_CLASS(VIDEO_ENHANCE)),
XE_RTP_ACTIONS(WHITELIST_OAM_MMIO_TRG)
},
--
2.52.0
next prev parent reply other threads:[~2026-01-08 0:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 0:20 [PATCH 0/4] Start fixing OA whitelist mistakes Matt Roper
2026-01-08 0:20 ` [PATCH 1/4] drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2 Matt Roper
2026-01-08 0:20 ` [PATCH 2/4] drm/xe/oa: Stop whitelisting OAG_OASTATUS Matt Roper
2026-01-08 0:20 ` Matt Roper [this message]
2026-01-08 0:20 ` [PATCH 4/4] drm/xe/oa: Stop whitelisting OAG registers after Xe3 Matt Roper
2026-01-08 0:26 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes Patchwork
2026-01-08 0:27 ` ✓ CI.KUnit: success " Patchwork
2026-01-08 1:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-08 2:43 ` ✗ Xe.CI.Full: failure " Patchwork
2026-02-26 23:20 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes (rev2) Patchwork
2026-02-26 23:22 ` ✓ CI.KUnit: success " Patchwork
2026-02-27 0:45 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27 6:58 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108002000.384449-9-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox