From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH 1/4] drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2
Date: Wed, 7 Jan 2026 16:20:02 -0800 [thread overview]
Message-ID: <20260108002000.384449-7-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20260108002000.384449-6-matthew.d.roper@intel.com>
OAG_MMIOTRIGGER should only be software whitelisted on DG2's Xe_HPG IP
to satisfy Wa_1809940648. The register did not exist before Xe_HPG (and
thus should not be whitelisted on Xe_LP platforms) and was part of the
hardware's builtin whitelist for all relevant engines/units on the
production steppings of all subsequent platforms.
Bspec: 45546, 60151
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/xe/xe_reg_whitelist.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c
index 1391cb6ec9c6..1bcb01f93914 100644
--- a/drivers/gpu/drm/xe/xe_reg_whitelist.c
+++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c
@@ -55,6 +55,14 @@ static const struct xe_rtp_entry_sr register_whitelist[] = {
RING_FORCE_TO_NONPRIV_ACCESS_RD,
XE_RTP_ACTION_FLAG(ENGINE_BASE)))
},
+ { XE_RTP_NAME("1809940648_rcs"),
+ XE_RTP_RULES(GRAPHICS_VERSION(1255), ENGINE_CLASS(RENDER)),
+ XE_RTP_ACTIONS(WHITELIST(OAG_MMIOTRIGGER, 0))
+ },
+ { XE_RTP_NAME("1809940648_ccs"),
+ XE_RTP_RULES(GRAPHICS_VERSION(1255), ENGINE_CLASS(COMPUTE)),
+ XE_RTP_ACTIONS(WHITELIST(OAG_MMIOTRIGGER, 0))
+ },
{ XE_RTP_NAME("16014440446"),
XE_RTP_RULES(PLATFORM(PVC)),
XE_RTP_ACTIONS(WHITELIST(XE_REG(0x4400),
@@ -83,27 +91,23 @@ static const struct xe_rtp_entry_sr register_whitelist[] = {
RING_FORCE_TO_NONPRIV_ACCESS_RW))
},
-#define WHITELIST_OA_MMIO_TRG(trg, status, head) \
- WHITELIST(trg, RING_FORCE_TO_NONPRIV_ACCESS_RW), \
+#define WHITELIST_OA_MMIO_TRG(status, head) \
WHITELIST(status, RING_FORCE_TO_NONPRIV_ACCESS_RD), \
WHITELIST(head, RING_FORCE_TO_NONPRIV_ACCESS_RD | RING_FORCE_TO_NONPRIV_RANGE_4)
#define WHITELIST_OAG_MMIO_TRG \
- WHITELIST_OA_MMIO_TRG(OAG_MMIOTRIGGER, OAG_OASTATUS, OAG_OAHEADPTR)
+ WHITELIST_OA_MMIO_TRG(OAG_OASTATUS, OAG_OAHEADPTR)
#define WHITELIST_OAM_MMIO_TRG \
- WHITELIST_OA_MMIO_TRG(OAM_MMIO_TRG(XE_OAM_SAG_BASE_ADJ), \
- OAM_STATUS(XE_OAM_SAG_BASE_ADJ), \
+ WHITELIST_OA_MMIO_TRG(OAM_STATUS(XE_OAM_SAG_BASE_ADJ), \
OAM_HEAD_POINTER(XE_OAM_SAG_BASE_ADJ)), \
- WHITELIST_OA_MMIO_TRG(OAM_MMIO_TRG(XE_OAM_SCMI_0_BASE_ADJ), \
- OAM_STATUS(XE_OAM_SCMI_0_BASE_ADJ), \
+ WHITELIST_OA_MMIO_TRG(OAM_STATUS(XE_OAM_SCMI_0_BASE_ADJ), \
OAM_HEAD_POINTER(XE_OAM_SCMI_0_BASE_ADJ)), \
- WHITELIST_OA_MMIO_TRG(OAM_MMIO_TRG(XE_OAM_SCMI_1_BASE_ADJ), \
- OAM_STATUS(XE_OAM_SCMI_1_BASE_ADJ), \
+ WHITELIST_OA_MMIO_TRG(OAM_STATUS(XE_OAM_SCMI_1_BASE_ADJ), \
OAM_HEAD_POINTER(XE_OAM_SCMI_1_BASE_ADJ))
#define WHITELIST_OA_MERT_MMIO_TRG \
- WHITELIST_OA_MMIO_TRG(OAMERT_MMIO_TRG, OAMERT_STATUS, OAMERT_HEAD_POINTER)
+ WHITELIST_OA_MMIO_TRG(OAMERT_STATUS, OAMERT_HEAD_POINTER)
{ XE_RTP_NAME("oag_mmio_trg_rcs"),
XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED),
--
2.52.0
next prev parent reply other threads:[~2026-01-08 0:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 0:20 [PATCH 0/4] Start fixing OA whitelist mistakes Matt Roper
2026-01-08 0:20 ` Matt Roper [this message]
2026-01-08 0:20 ` [PATCH 2/4] drm/xe/oa: Stop whitelisting OAG_OASTATUS Matt Roper
2026-01-08 0:20 ` [PATCH 3/4] drm/xe/oa: Stop whitelisting OAM registers on non Xe2/Xe3 Matt Roper
2026-01-08 0:20 ` [PATCH 4/4] drm/xe/oa: Stop whitelisting OAG registers after Xe3 Matt Roper
2026-01-08 0:26 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes Patchwork
2026-01-08 0:27 ` ✓ CI.KUnit: success " Patchwork
2026-01-08 1:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-08 2:43 ` ✗ Xe.CI.Full: failure " Patchwork
2026-02-26 23:20 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes (rev2) Patchwork
2026-02-26 23:22 ` ✓ CI.KUnit: success " Patchwork
2026-02-27 0:45 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27 6:58 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108002000.384449-7-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox