Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] Start fixing OA whitelist mistakes
@ 2026-01-08  0:20 Matt Roper
  2026-01-08  0:20 ` [PATCH 1/4] drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2 Matt Roper
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: Matt Roper @ 2026-01-08  0:20 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper

There are a number of mistakes in the OA register whitelists:
 - Unlimited upper bounds (never allowed for whitelists entries!)
 - Whitelisting registers that userspace already has access to
 - Whitelisting registers that userspace is not intended to ever need
   access to

Correct the first two bullets above.  The third bullet will need more
investigation to determine whether any userspace has developed an
unnecessary and unwanted dependency on these registers (in which case we
can't easily take them away without breaking userspace).

Going forward we should also probably unmacro-ize these OA entries
because they make it harder to see exactly which register(s) are being
whitelisted and harder to audit against the formally allowed lists.


Matt Roper (4):
  drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2
  drm/xe/oa: Stop whitelisting OAG_OASTATUS
  drm/xe/oa: Stop whitelisting OAM registers on non Xe2/Xe3
  drm/xe/oa: Stop whitelisting OAG registers after Xe3

 drivers/gpu/drm/xe/xe_reg_whitelist.c | 41 +++++++++++++++------------
 1 file changed, 23 insertions(+), 18 deletions(-)

-- 
2.52.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-02-27  6:58 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08  0:20 [PATCH 0/4] Start fixing OA whitelist mistakes Matt Roper
2026-01-08  0:20 ` [PATCH 1/4] drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2 Matt Roper
2026-01-08  0:20 ` [PATCH 2/4] drm/xe/oa: Stop whitelisting OAG_OASTATUS Matt Roper
2026-01-08  0:20 ` [PATCH 3/4] drm/xe/oa: Stop whitelisting OAM registers on non Xe2/Xe3 Matt Roper
2026-01-08  0:20 ` [PATCH 4/4] drm/xe/oa: Stop whitelisting OAG registers after Xe3 Matt Roper
2026-01-08  0:26 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes Patchwork
2026-01-08  0:27 ` ✓ CI.KUnit: success " Patchwork
2026-01-08  1:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-08  2:43 ` ✗ Xe.CI.Full: failure " Patchwork
2026-02-26 23:20 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes (rev2) Patchwork
2026-02-26 23:22 ` ✓ CI.KUnit: success " Patchwork
2026-02-27  0:45 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27  6:58 ` ✗ Xe.CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox