Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH 0/4] Start fixing OA whitelist mistakes
Date: Wed,  7 Jan 2026 16:20:01 -0800	[thread overview]
Message-ID: <20260108002000.384449-6-matthew.d.roper@intel.com> (raw)

There are a number of mistakes in the OA register whitelists:
 - Unlimited upper bounds (never allowed for whitelists entries!)
 - Whitelisting registers that userspace already has access to
 - Whitelisting registers that userspace is not intended to ever need
   access to

Correct the first two bullets above.  The third bullet will need more
investigation to determine whether any userspace has developed an
unnecessary and unwanted dependency on these registers (in which case we
can't easily take them away without breaking userspace).

Going forward we should also probably unmacro-ize these OA entries
because they make it harder to see exactly which register(s) are being
whitelisted and harder to audit against the formally allowed lists.


Matt Roper (4):
  drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2
  drm/xe/oa: Stop whitelisting OAG_OASTATUS
  drm/xe/oa: Stop whitelisting OAM registers on non Xe2/Xe3
  drm/xe/oa: Stop whitelisting OAG registers after Xe3

 drivers/gpu/drm/xe/xe_reg_whitelist.c | 41 +++++++++++++++------------
 1 file changed, 23 insertions(+), 18 deletions(-)

-- 
2.52.0


             reply	other threads:[~2026-01-08  0:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  0:20 Matt Roper [this message]
2026-01-08  0:20 ` [PATCH 1/4] drm/xe/oa: Stop whitelisting MMIO_TRG registers on non-DG2 Matt Roper
2026-01-08  0:20 ` [PATCH 2/4] drm/xe/oa: Stop whitelisting OAG_OASTATUS Matt Roper
2026-01-08  0:20 ` [PATCH 3/4] drm/xe/oa: Stop whitelisting OAM registers on non Xe2/Xe3 Matt Roper
2026-01-08  0:20 ` [PATCH 4/4] drm/xe/oa: Stop whitelisting OAG registers after Xe3 Matt Roper
2026-01-08  0:26 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes Patchwork
2026-01-08  0:27 ` ✓ CI.KUnit: success " Patchwork
2026-01-08  1:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-08  2:43 ` ✗ Xe.CI.Full: failure " Patchwork
2026-02-26 23:20 ` ✗ CI.checkpatch: warning for Start fixing OA whitelist mistakes (rev2) Patchwork
2026-02-26 23:22 ` ✓ CI.KUnit: success " Patchwork
2026-02-27  0:45 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27  6:58 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108002000.384449-6-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox