public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Arun R Murthy <arun.r.murthy@intel.com>
To: "Imre Deak" <imre.deak@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	 intel-xe@lists.freedesktop.org,
	Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH RFC 0/4] DP: Read LTTPR caps followed by DPRX caps
Date: Thu, 05 Mar 2026 13:48:10 +0530	[thread overview]
Message-ID: <20260305-dp_aux-v1-0-54ee0b5f5158@intel.com> (raw)

As per the spec  DP2.1 section 3.6.8.6.1, section 2.12.1,
section 2.12.3 (Link Policy) the LTTPR caps is to be read first
followed by the DPRX capability.

Git log shows that initially drm dp helper exposed function to read
lttpr caps. Driver reads the lttpr caps and then the dprx caps.
For a particular issue 
https://gitlab.freedesktop.org/drm/intel/-/issues/3415
as a workaround reading dprx caps was done first to know if the panel is
< DP1.4 and then read 1 block at a time for lttpr caps.

This can be handled in a better way and two such ways is what I see.
1. Read LTTPR caps followed by DPRX caps as per the spec. Then on
reading dprx caps if revision < 1.4 then re-read the lttpr caps one
block at a time.

2. Read LTTPR caps and if 8b/10b check for correctness of the link rate
supported(lttpr caps 0xf0001), if some corrupted value is read then read
one block at a time.

I am open for either of the two or you have any other options as well I
am open.

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
Arun R Murthy (4):
      drm/display/dp: Read LTTPR caps without DPRX caps
      drm/i915/dp: Read LTTPR caps followed by DPRX caps
      drm/i915/dp: On HPD read LTTPR caps followed by DPRX caps
      drm/i915/dp: DPRX/LTTPR caps for DP should be read once

 drivers/gpu/drm/display/drm_dp_helper.c            | 63 ++++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dp.c            |  3 +-
 .../gpu/drm/i915/display/intel_dp_link_training.c  | 40 +++++++-------
 .../gpu/drm/i915/display/intel_dp_link_training.h  |  1 -
 drivers/gpu/drm/i915/display/intel_dp_tunnel.c     |  3 +-
 include/drm/display/drm_dp_helper.h                |  2 +
 6 files changed, 86 insertions(+), 26 deletions(-)
---
base-commit: cfc20c776480fda8c1b0517b187bb71ec0781cd4
change-id: 20260305-dp_aux-1e27599e06c8

Best regards,
-- 
Arun R Murthy <arun.r.murthy@intel.com>


             reply	other threads:[~2026-03-05  8:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05  8:18 Arun R Murthy [this message]
2026-03-05  8:18 ` [PATCH RFC 1/4] drm/display/dp: Read LTTPR caps without DPRX caps Arun R Murthy
2026-03-05  9:18   ` Jani Nikula
2026-03-06  4:08     ` Murthy, Arun R
2026-03-05 16:29   ` Imre Deak
2026-03-06  4:10     ` Murthy, Arun R
2026-03-05  8:18 ` [PATCH RFC 2/4] drm/i915/dp: Read LTTPR caps followed by " Arun R Murthy
2026-03-05  8:18 ` [PATCH RFC 3/4] drm/i915/dp: On HPD read " Arun R Murthy
2026-03-05  8:18 ` [PATCH RFC 4/4] drm/i915/dp: DPRX/LTTPR caps for DP should be read once Arun R Murthy
2026-03-05 16:11 ` [PATCH RFC 0/4] DP: Read LTTPR caps followed by DPRX caps Imre Deak
2026-03-06  4:29   ` Murthy, Arun R
2026-03-06  9:46     ` Imre Deak
2026-03-10  8:58       ` Murthy, Arun R
2026-03-06  4:29   ` Murthy, Arun R
2026-03-06  3:42 ` ✗ CI.checkpatch: warning for " Patchwork
2026-03-06  3:44 ` ✓ CI.KUnit: success " Patchwork
2026-03-06  4:33 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-03-07  1:55 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305-dp_aux-v1-0-54ee0b5f5158@intel.com \
    --to=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox