From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 7/9] drm/i915/wm: Extract skl_print_plane_ddb_changes()
Date: Thu, 19 Mar 2026 13:40:32 +0200 [thread overview]
Message-ID: <20260319114034.7093-8-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260319114034.7093-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We have skl_print_plane_wm_changes() but the DDB counterpart is
just inline in the main loop. Extract it into a function. We'll
ave a second use for this soon.
The "ddb" part is already parametrized in anticipation of the
second user.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/skl_watermark.c | 22 +++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 6c8dab847ae2..8687026935e9 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -2601,6 +2601,21 @@ static char enast(bool enable)
return enable ? '*' : ' ';
}
+static void
+skl_print_plane_ddb_changes(struct intel_plane *plane,
+ const struct skl_ddb_entry *old,
+ const struct skl_ddb_entry *new,
+ const char *ddb_name)
+{
+ struct intel_display *display = to_intel_display(plane);
+
+ drm_dbg_kms(display->drm,
+ "[PLANE:%d:%s] %s (%4d - %4d) -> (%4d - %4d), size %4d -> %4d\n",
+ plane->base.base.id, plane->base.name, ddb_name,
+ old->start, old->end, new->start, new->end,
+ skl_ddb_entry_size(old), skl_ddb_entry_size(new));
+}
+
static noinline_for_stack void
skl_print_plane_wm_changes(struct intel_plane *plane,
const struct skl_plane_wm *old_wm,
@@ -2722,11 +2737,8 @@ skl_print_wm_changes(struct intel_atomic_state *state)
if (skl_ddb_entry_equal(old, new))
continue;
- drm_dbg_kms(display->drm,
- "[PLANE:%d:%s] ddb (%4d - %4d) -> (%4d - %4d), size %4d -> %4d\n",
- plane->base.base.id, plane->base.name,
- old->start, old->end, new->start, new->end,
- skl_ddb_entry_size(old), skl_ddb_entry_size(new));
+
+ skl_print_plane_ddb_changes(plane, old, new, "ddb");
}
for_each_intel_plane_on_crtc(display->drm, crtc, plane) {
--
2.52.0
next prev parent reply other threads:[~2026-03-19 11:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 11:40 [PATCH 0/9] drm/i915/wm: Clean up pre-icl NV12 watermarks Ville Syrjala
2026-03-19 11:40 ` [PATCH 1/9] drm/i915/wm: Nuke is_planar from skl+ wm structures Ville Syrjala
2026-03-19 12:27 ` Jani Nikula
2026-03-19 11:40 ` [PATCH 2/9] drm/i915/wm: Reorder the arguments to skl_allocate_plane_ddb() Ville Syrjala
2026-03-19 12:28 ` Jani Nikula
2026-03-19 11:40 ` [PATCH 3/9] drm/i915/wm: s/skl_check_nv12_wm_level()/skl_check_wm_level_nv12()/ Ville Syrjala
2026-03-19 13:07 ` Jani Nikula
2026-03-19 11:40 ` [PATCH 4/9] drm/i915/wm: Extract skl_allocate_plane_ddb_nv12() Ville Syrjala
2026-03-19 13:21 ` Jani Nikula
2026-03-19 11:40 ` [PATCH 5/9] drm/i915/wm: Nuke wm->uv_wm[] Ville Syrjala
2026-03-19 14:06 ` Jani Nikula
2026-03-19 11:40 ` [PATCH 6/9] drm/i915/wm: s/skl_print_plane_changes()/skl_print_plane_wm_changes()/ Ville Syrjala
2026-03-19 13:36 ` Jani Nikula
2026-03-19 11:40 ` Ville Syrjala [this message]
2026-03-19 13:38 ` [PATCH 7/9] drm/i915/wm: Extract skl_print_plane_ddb_changes() Jani Nikula
2026-03-19 11:40 ` [PATCH 8/9] drm/i915/wm: Include ddb_y in skl_print_wm_changes() on pre-icl Ville Syrjala
2026-03-19 13:44 ` Jani Nikula
2026-03-19 14:03 ` Ville Syrjälä
2026-03-19 11:40 ` [PATCH 9/9] drm/i915/wm: Include .min_ddb_alloc_uv in the wm dumps Ville Syrjala
2026-03-19 14:01 ` Jani Nikula
2026-03-19 11:48 ` ✓ CI.KUnit: success for drm/i915/wm: Clean up pre-icl NV12 watermarks Patchwork
2026-03-19 12:39 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-20 13:27 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319114034.7093-8-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox