Re: [PATCH V20 10/15] drm/xe/configfs: Add disable_vram_page_offline attribute

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Misplaced documentation comment restricting the attribute to CRI.
--

commit 4299f8f46041fce362473361938b350fd32fe701
Author: Tejas Upadhyay <tejas.upadhyay@intel.com>

drm/xe/configfs: Add disable_vram_page_offline attribute

This commit adds a new configfs attribute disable_vram_page_offline
to control how bad VRAM pages are handled. It allows administrators to 
disable active VRAM page offlining on Crescent Island (CRI) platforms,
falling back to logging only.

> diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
> index 052cce9621611..a9c72504c8a44 100644
> --- a/drivers/gpu/drm/xe/xe_configfs.c
> +++ b/drivers/gpu/drm/xe/xe_configfs.c
[ ... ]
> @@ -157,6 +158,18 @@
>   *
>   *	# echo 1 > /sys/kernel/config/xe/0000:03:00.0/enable_psmi
>   *
> + * This attribute can only be set on CRI before binding to the device.

[Severity: Low]
Does this documentation string apply to enable_psmi or the newly added
disable_vram_page_offline attribute?

Because it is placed above the "Disable VRAM page offline:" heading, it
appears to document enable_psmi. However, since the code restricts
disable_vram_page_offline to XE_CRESCENTISLAND (CRI), it seems this
restriction text was intended for the new attribute instead.

Additionally, placing the new text here pushes the original
"This attribute can only be set before binding to the device." text
down into the disable_vram_page_offline section, which removes it from
the enable_psmi section where it previously belonged.

> + *
> + * Disable VRAM page offline:
> + * ----------------------------
> + *
> + *  0, n, N, false - Do not disable (Offlining is active - default)
> + *  1, y, Y, true  - Disable vram page offline (Logging only)
> + *
> + *  Example to disable VRAM offline::
> + *
> + *      # echo 1 > /sys/kernel/config/xe/0000:03:00.0/disable_vram_page_offline
> + *
>   * This attribute can only be set before binding to the device.
>   *
>   * Context restore BB

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902145343.465686-17-tejas.upadhyay@intel.com?part=10