Re: [PATCH 04/13] drm/xe/mmio: Allow to replace xe_mmio_read32|write32() with stub

["K V P, Satyanarayana" <satyanarayana.k.v.p@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

On 28-Apr-26 7:57 PM, Michal Wajdeczko wrote:
> We want to use replacement functions in upcoming kunit tests.
>
> Signed-off-by: Michal Wajdeczko<michal.wajdeczko@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_mmio.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
> index 78adb303b663..83cd1157cf61 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.c
> +++ b/drivers/gpu/drm/xe/xe_mmio.c
> @@ -10,6 +10,8 @@
>   #include <linux/minmax.h>
>   #include <linux/pci.h>
>   
> +#include <kunit/static_stub.h>
> +
>   #include <drm/drm_managed.h>
>   #include <drm/drm_print.h>
>   
> @@ -180,6 +182,8 @@ void xe_mmio_write32(struct xe_mmio *mmio, struct xe_reg reg, u32 val)
>   {
>   	u32 addr = xe_mmio_adjusted_addr(mmio, reg.addr);
>   
> +	KUNIT_STATIC_STUB_REDIRECT(xe_mmio_write32, mmio, reg, val);
> +
>   	trace_xe_reg_rw(mmio, true, addr, val, sizeof(val));
>   
>   	if (!reg.vf && IS_SRIOV_VF(mmio->tile->xe))
> @@ -194,6 +198,8 @@ u32 xe_mmio_read32(struct xe_mmio *mmio, struct xe_reg reg)
>   	u32 addr = xe_mmio_adjusted_addr(mmio, reg.addr);
>   	u32 val;
>   
> +	KUNIT_STATIC_STUB_REDIRECT(xe_mmio_read32, mmio, reg);
> +
>   	mmio_flush_pending_writes(mmio);
>   
>   	if (!reg.vf && IS_SRIOV_VF(mmio->tile->xe))

LGTM.

Reviewed-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>

[-- Attachment #2: Type: text/html, Size: 2142 bytes --]