Re: [PATCH 01/13] drm/xe/ggtt: Rename parameter name in xe_ggtt_init_kunit()

["Summers, Stuart" <stuart.summers@intel.com>]

On Thu, 2026-04-30 at 11:32 +0300, Jani Nikula wrote:
> On Wed, 29 Apr 2026, "Summers, Stuart" <stuart.summers@intel.com>
> wrote:
> > On Tue, 2026-04-28 at 16:27 +0200, Michal Wajdeczko wrote:
> > > The parameter name was changed by the commit 22437f30d2f0
> > > ("drm/xe:
> > > Start using ggtt->start in preparation of balloon removal"), but
> > > we
> > > missed then to update the function prototype.
> > > 
> > 
> > Include the Fixes:?
> 
> Does it really matter? It'll lead to a stable backport of an
> inconsequental parameter rename.

Yeah it's a fair point. Anyway not a blocker from me.

-Stuart

> 
> BR,
> Jani.
> 
> 
> > 
> > Otherwise the change looks good I agree:
> > Reviewed-by: Stuart Summers <stuart.summers@intel.com>
> > 
> > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > > ---
> > > Cc: Maarten Lankhorst <dev@lankhorst.se>
> > > ---
> > >  drivers/gpu/drm/xe/xe_ggtt.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_ggtt.h
> > > b/drivers/gpu/drm/xe/xe_ggtt.h
> > > index c864cc975a69..f0ac7ec0502a 100644
> > > --- a/drivers/gpu/drm/xe/xe_ggtt.h
> > > +++ b/drivers/gpu/drm/xe/xe_ggtt.h
> > > @@ -15,7 +15,7 @@ struct drm_exec;
> > >  
> > >  struct xe_ggtt *xe_ggtt_alloc(struct xe_tile *tile);
> > >  int xe_ggtt_init_early(struct xe_ggtt *ggtt);
> > > -int xe_ggtt_init_kunit(struct xe_ggtt *ggtt, u32 reserved, u32
> > > size);
> > > +int xe_ggtt_init_kunit(struct xe_ggtt *ggtt, u32 start, u32
> > > size);
> > >  int xe_ggtt_init(struct xe_ggtt *ggtt);
> > >  
> > >  void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_base);
> > 
>