public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, arun.r.murthy@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: Re: [PATCH 08/12] drm/i915/display: Add HAS_CMN_SDP_TL macro
Date: Mon, 13 Apr 2026 11:37:19 +0300	[thread overview]
Message-ID: <302ca6518ca69410026fade5f37e245a2884b031@intel.com> (raw)
In-Reply-To: <20260413035349.1730312-9-ankit.k.nautiyal@intel.com>

On Mon, 13 Apr 2026, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
> Add a helper macro to detect CMN SDP TL support on platforms with display
> version 35 and above.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 9338ea087e92..36a8a956f54a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -154,6 +154,7 @@ struct intel_display_platforms {
>  #define HAS_CASF(__display)		(DISPLAY_VER(__display) >= 20)
>  #define HAS_CDCLK_CRAWL(__display)	(DISPLAY_INFO(__display)->has_cdclk_crawl)
>  #define HAS_CDCLK_SQUASH(__display)	(DISPLAY_INFO(__display)->has_cdclk_squash)
> +#define HAS_CMN_SDP_TL(__display)	(DISPLAY_VER(__display) >= 35)

Even if the register is called CMN, we can actually use the word COMMON
here.

>  #define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
>  #define HAS_CMTG(__display)		(!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
>  #define HAS_CUR_FBC(__display)		(!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-04-13  8:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  3:53 [PATCH 00/12] Add support for Common SDP Transmission Line Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 01/12] drm/i915/vrr: Add HAS_EMP_AS_SDP_TL macro Ankit Nautiyal
2026-04-13  8:31   ` Jani Nikula
2026-04-13  8:58     ` Nautiyal, Ankit K
2026-04-13  3:53 ` [PATCH 02/12] drm/i915/vrr: Add helper to readback EMP_AS_SDP_TL Ankit Nautiyal
2026-04-13  8:32   ` Jani Nikula
2026-04-13  9:25   ` Ville Syrjälä
2026-04-13  9:54     ` Nautiyal, Ankit K
2026-04-13 10:21       ` Ville Syrjälä
2026-04-13  3:53 ` [PATCH 03/12] drm/i915/vrr: Separate out helper to write EMP_AS_SDP_TL Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 04/12] drm/i915/dp: Add helper to get AS SDP Transmission Line Ankit Nautiyal
2026-04-13  8:34   ` Jani Nikula
2026-04-13  9:38     ` Nautiyal, Ankit K
2026-04-13  3:53 ` [PATCH 05/12] drm/i915/dp: Add crtc state for AS SDP transmission line Ankit Nautiyal
2026-04-13  8:36   ` Jani Nikula
2026-04-13  9:36     ` Nautiyal, Ankit K
2026-04-13  3:53 ` [PATCH 06/12] drm/i915/dp: Store and use AS SDP transmission line from crtc state Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 07/12] drm/i915/nvl: Add register definitions for common SDP Transmission Line Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 08/12] drm/i915/display: Add HAS_CMN_SDP_TL macro Ankit Nautiyal
2026-04-13  8:37   ` Jani Nikula [this message]
2026-04-13  3:53 ` [PATCH 09/12] drm/i915/dp: Store SDP transmission lines in crtc_state Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 10/12] drm/i915/dp: Introduce helpers to enable/disable CMN SDP Transmission line Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 11/12] drm/i915/dp: Enable Common " Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 12/12] drm/i915/display: Dump SDP Transmission lines Ankit Nautiyal
2026-04-13  4:18 ` ✗ CI.checkpatch: warning for Add support for Common SDP Transmission Line (rev2) Patchwork
2026-04-13  4:19 ` ✓ CI.KUnit: success " Patchwork
2026-04-13  5:00 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-13  6:04 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=302ca6518ca69410026fade5f37e245a2884b031@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox