From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: Re: [PATCH 2/5] drm/xe/oa/uapi: Add gt_id to struct drm_xe_oa_unit
Date: Wed, 26 Nov 2025 15:08:33 -0800 [thread overview]
Message-ID: <857bvc5r4e.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <aSdmTbYbOiJv4i8r@lstrano-desk.jf.intel.com>
On Wed, 26 Nov 2025 12:42:53 -0800, Matthew Brost wrote:
>
> > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> > index 47853659a705e..ec09b281eafe7 100644
> > --- a/include/uapi/drm/xe_drm.h
> > +++ b/include/uapi/drm/xe_drm.h
> > @@ -1676,12 +1676,16 @@ struct drm_xe_oa_unit {
> > #define DRM_XE_OA_CAPS_OA_BUFFER_SIZE (1 << 2)
> > #define DRM_XE_OA_CAPS_WAIT_NUM_REPORTS (1 << 3)
> > #define DRM_XE_OA_CAPS_OAM (1 << 4)
> > +#define DRM_XE_OA_CAPS_OA_UNIT_GT_ID (1 << 5)
> >
> > /** @oa_timestamp_freq: OA timestamp freq */
> > __u64 oa_timestamp_freq;
> >
> > + /** @gt_id: gt id for this OA unit */
> > + __u64 gt_id;
>
> u64 seems like overkill. Maybe a u32 or u16 to save some bits for the future?
Sure, will change to u16 before merging.
>
> > +
> > /** @reserved: MBZ */
> > - __u64 reserved[4];
> > + __u64 reserved[3];
> >
> > /** @num_engines: number of engines in @eci array */
> > __u64 num_engines;
> > --
> > 2.48.1
> >
next prev parent reply other threads:[~2025-11-26 23:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 3:52 [PATCH 0/5] OA: More OA and register whitelist changes Ashutosh Dixit
2025-11-26 3:52 ` [PATCH 1/5] drm/xe/oa: Use explicit struct initialization for struct xe_oa_regs Ashutosh Dixit
2025-11-26 18:41 ` Umesh Nerlige Ramappa
2025-11-26 3:52 ` [PATCH 2/5] drm/xe/oa/uapi: Add gt_id to struct drm_xe_oa_unit Ashutosh Dixit
2025-11-26 20:14 ` Umesh Nerlige Ramappa
2025-11-26 20:42 ` Matthew Brost
2025-11-26 23:08 ` Dixit, Ashutosh [this message]
2025-12-01 18:01 ` Rodrigo Vivi
2025-11-26 3:52 ` [PATCH 3/5] drm/xe/oa: Allow exec_queue's to be specified only for OAG OA unit Ashutosh Dixit
2025-11-26 20:15 ` Umesh Nerlige Ramappa
2025-11-26 3:52 ` [PATCH 4/5] drm/xe/rtp: Refactor OAG MMIO trigger register whitelisting Ashutosh Dixit
2025-11-26 21:49 ` Umesh Nerlige Ramappa
2025-11-26 3:52 ` [PATCH 5/5] drm/xe/rtp: Whitelist OAM MMIO trigger registers Ashutosh Dixit
2025-11-26 21:53 ` Umesh Nerlige Ramappa
2025-11-26 5:35 ` ✗ CI.checkpatch: warning for OA: More OA and register whitelist changes Patchwork
2025-11-26 5:36 ` ✓ CI.KUnit: success " Patchwork
2025-11-26 6:14 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-26 9:02 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857bvc5r4e.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox