Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Give i915 and xe each their own display tracepoints
@ 2025-01-27 21:30 Ville Syrjala
  2025-01-27 21:40 ` Cavitt, Jonathan
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: Ville Syrjala @ 2025-01-27 21:30 UTC (permalink / raw)
  To: intel-gfx; +Cc: intel-xe

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Currently we just define the display tracpoints with
TRACE_SYSTEM i915. However the code gets included separately
in i915 and xe, and now both modules are competing for the
same tracpoints. Apparently whichever module is loaded first
gets the tracepoints and the other guy is left with nothing.

Give each module its own set of display tracpoints so that
things work even when both modules are loaded.

This one had me stumped for a bit when after a reboot I lost
all i915 display tracpoints (on account of the new kernel
also including xe, and something also ended up loading it
before I manually loaded i915).

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_trace.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
index 54a6e2a46b82..0e10c2856058 100644
--- a/drivers/gpu/drm/i915/display/intel_display_trace.h
+++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
@@ -4,7 +4,11 @@
  */
 
 #undef TRACE_SYSTEM
+#ifdef I915
 #define TRACE_SYSTEM i915
+#else
+#define TRACE_SYSTEM xe
+#endif
 
 #if !defined(__INTEL_DISPLAY_TRACE_H__) || defined(TRACE_HEADER_MULTI_READ)
 #define __INTEL_DISPLAY_TRACE_H__
-- 
2.45.3


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-01-28 16:50 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-27 21:30 [PATCH] drm/i915: Give i915 and xe each their own display tracepoints Ville Syrjala
2025-01-27 21:40 ` Cavitt, Jonathan
2025-01-28  9:50   ` Jani Nikula
2025-01-28 16:50   ` Ville Syrjälä
2025-01-27 22:22 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-27 22:22 ` ✓ CI.checkpatch: " Patchwork
2025-01-27 22:23 ` ✓ CI.KUnit: " Patchwork
2025-01-27 22:40 ` ✓ CI.Build: " Patchwork
2025-01-27 22:42 ` ✓ CI.Hooks: " Patchwork
2025-01-27 22:43 ` ✓ CI.checksparse: " Patchwork
2025-01-27 23:00 ` [PATCH] " Lucas De Marchi
2025-01-28 16:50   ` Ville Syrjälä
2025-01-27 23:04 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-01-28 11:55 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox