Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/xe/oa: Don't use hardcoded values
@ 2024-07-21  7:13 Ohad Sharabi
  2024-07-21  7:19 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Ohad Sharabi @ 2024-07-21  7:13 UTC (permalink / raw)
  To: intel-xe; +Cc: osharabi, ashutosh.dixit, obitton, kelbaz

The current implementation uses hardcoded values instead of common defines.

v2:
 - Make the commit a regular commit instead of a fixup commit
 - slightly modify commit message

Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
---
 drivers/gpu/drm/xe/xe_oa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index 6d69f751bf78..3ef92eb8fbb1 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -641,7 +641,7 @@ static void xe_oa_store_flex(struct xe_oa_stream *stream, struct xe_lrc *lrc,
 	u32 offset = xe_bo_ggtt_addr(lrc->bo);
 
 	do {
-		bb->cs[bb->len++] = MI_STORE_DATA_IMM | BIT(22) /* GGTT */ | 2;
+		bb->cs[bb->len++] = MI_STORE_DATA_IMM | MI_SDI_GGTT | MI_SDI_NUM_DW(1);
 		bb->cs[bb->len++] = offset + flex->offset * sizeof(u32);
 		bb->cs[bb->len++] = 0;
 		bb->cs[bb->len++] = flex->value;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-07-22  5:42 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-21  7:13 [PATCH v2] drm/xe/oa: Don't use hardcoded values Ohad Sharabi
2024-07-21  7:19 ` ✓ CI.Patch_applied: success for " Patchwork
2024-07-21  7:19 ` ✓ CI.checkpatch: " Patchwork
2024-07-21  7:20 ` ✓ CI.KUnit: " Patchwork
2024-07-21  7:32 ` ✓ CI.Build: " Patchwork
2024-07-21  7:34 ` ✓ CI.Hooks: " Patchwork
2024-07-21  7:35 ` ✓ CI.checksparse: " Patchwork
2024-07-21  7:55 ` ✓ CI.BAT: " Patchwork
2024-07-21  9:00 ` ✗ CI.FULL: failure " Patchwork
2024-07-21 15:11 ` [PATCH v2] " Dixit, Ashutosh
2024-07-22  5:36   ` Dixit, Ashutosh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox