Re: [Intel-xe] [PATCH v3 03/13] drm/sched: Move schedule policy to scheduler / entity

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Sep 12, 2023 at 10:11:56PM +0800, kernel test robot wrote:
> Hi Matthew,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on drm/drm-next]
> [also build test ERROR on drm-exynos/exynos-drm-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.6-rc1 next-20230912]
> [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/drm-sched-Add-drm_sched_submit_-helpers/20230912-102001
> base:   git://anongit.freedesktop.org/drm/drm drm-next
> patch link:    https://lore.kernel.org/r/20230912021615.2086698-4-matthew.brost%40intel.com
> patch subject: [PATCH v3 03/13] drm/sched: Move schedule policy to scheduler / entity
> config: arm64-randconfig-r032-20230912 (https://download.01.org/0day-ci/archive/20230912/202309122100.HAEi8ytJ-lkp@intel.com/config)
> compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309122100.HAEi8ytJ-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202309122100.HAEi8ytJ-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/gpu/drm/v3d/v3d_sched.c:403:9: error: use of undeclared identifier 'ULL'
>                                 ULL, "v3d_render", DRM_SCHED_POLICY_DEFAULT,
>                                 ^

Typos, s/ULL/NULL in next rev.

Matt

>    1 error generated.
> 
> 
> vim +/ULL +403 drivers/gpu/drm/v3d/v3d_sched.c
> 
>    381	
>    382	int
>    383	v3d_sched_init(struct v3d_dev *v3d)
>    384	{
>    385		int hw_jobs_limit = 1;
>    386		int job_hang_limit = 0;
>    387		int hang_limit_ms = 500;
>    388		int ret;
>    389	
>    390		ret = drm_sched_init(&v3d->queue[V3D_BIN].sched,
>    391				     &v3d_bin_sched_ops, NULL,
>    392				     hw_jobs_limit, job_hang_limit,
>    393				     msecs_to_jiffies(hang_limit_ms), NULL,
>    394				     NULL, "v3d_bin", DRM_SCHED_POLICY_DEFAULT,
>    395				     v3d->drm.dev);
>    396		if (ret)
>    397			return ret;
>    398	
>    399		ret = drm_sched_init(&v3d->queue[V3D_RENDER].sched,
>    400				     &v3d_render_sched_ops, NULL,
>    401				     hw_jobs_limit, job_hang_limit,
>    402				     msecs_to_jiffies(hang_limit_ms), NULL,
>  > 403				     ULL, "v3d_render", DRM_SCHED_POLICY_DEFAULT,
>    404				     v3d->drm.dev);
>    405		if (ret)
>    406			goto fail;
>    407	
>    408		ret = drm_sched_init(&v3d->queue[V3D_TFU].sched,
>    409				     &v3d_tfu_sched_ops, NULL,
>    410				     hw_jobs_limit, job_hang_limit,
>    411				     msecs_to_jiffies(hang_limit_ms), NULL,
>    412				     NULL, "v3d_tfu", DRM_SCHED_POLICY_DEFAULT,
>    413				     v3d->drm.dev);
>    414		if (ret)
>    415			goto fail;
>    416	
>    417		if (v3d_has_csd(v3d)) {
>    418			ret = drm_sched_init(&v3d->queue[V3D_CSD].sched,
>    419					     &v3d_csd_sched_ops, NULL,
>    420					     hw_jobs_limit, job_hang_limit,
>    421					     msecs_to_jiffies(hang_limit_ms), NULL,
>    422					     NULL, "v3d_csd", DRM_SCHED_POLICY_DEFAULT,
>    423					     v3d->drm.dev);
>    424			if (ret)
>    425				goto fail;
>    426	
>    427			ret = drm_sched_init(&v3d->queue[V3D_CACHE_CLEAN].sched,
>    428					     &v3d_cache_clean_sched_ops, NULL,
>    429					     hw_jobs_limit, job_hang_limit,
>    430					     msecs_to_jiffies(hang_limit_ms), NULL,
>    431					     NULL, "v3d_cache_clean",
>    432					     DRM_SCHED_POLICY_DEFAULT, v3d->drm.dev);
>    433			if (ret)
>    434				goto fail;
>    435		}
>    436	
>    437		return 0;
>    438	
>    439	fail:
>    440		v3d_sched_fini(v3d);
>    441		return ret;
>    442	}
>    443	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki