Re: [PATCH 08/16] drm/xe/multi_queue: Add multi queue information to guc_info dump

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Oct 31, 2025 at 11:29:28AM -0700, Niranjana Vishwanathapura wrote:
> Dump multi queue specific information in the guc exec queue
> dump.
> 
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c       | 10 ++++++++++
>  drivers/gpu/drm/xe/xe_guc_submit_types.h | 13 +++++++++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 426b64ef8d99..b84a0be2eefe 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -3032,6 +3032,11 @@ xe_guc_exec_queue_snapshot_capture(struct xe_exec_queue *q)
>  	if (snapshot->parallel_execution)
>  		guc_exec_queue_wq_snapshot_capture(q, snapshot);
>  
> +	snapshot->is_multi_queue = xe_exec_queue_is_multi_queue(q);
> +	if (snapshot->is_multi_queue) {
> +		snapshot->multi_queue.primary = xe_exec_queue_multi_queue_primary(q)->guc->id;
> +		snapshot->multi_queue.pos = q->multi_queue.pos;
> +	}
>  	spin_lock(&sched->base.job_list_lock);
>  	snapshot->pending_list_size = list_count_nodes(&sched->base.pending_list);
>  	snapshot->pending_list = kmalloc_array(snapshot->pending_list_size,
> @@ -3114,6 +3119,11 @@ xe_guc_exec_queue_snapshot_print(struct xe_guc_submit_exec_queue_snapshot *snaps
>  	if (snapshot->parallel_execution)
>  		guc_exec_queue_wq_snapshot_print(snapshot, p);
>  
> +	if (snapshot->is_multi_queue) {
> +		drm_printf(p, "\tMulti queue primary GuC ID: %d\n", snapshot->multi_queue.primary);
> +		drm_printf(p, "\tMulti queue position: %d\n", snapshot->multi_queue.pos);
> +	}
> +
>  	for (i = 0; snapshot->pending_list && i < snapshot->pending_list_size;
>  	     i++)
>  		drm_printf(p, "\tJob: seqno=%d, fence=%d, finished=%d\n",
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit_types.h b/drivers/gpu/drm/xe/xe_guc_submit_types.h
> index dc7456c34583..20dddf50d802 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit_types.h
> +++ b/drivers/gpu/drm/xe/xe_guc_submit_types.h
> @@ -135,6 +135,19 @@ struct xe_guc_submit_exec_queue_snapshot {
>  		u32 wq[WQ_SIZE / sizeof(u32)];
>  	} parallel;
>  
> +	/** @is_multi_queue: The exec queue is part of a multi queue group */
> +	bool is_multi_queue;

I'd stick this in the sub-structure.

Otherwise LGTM.

With this nit fixed:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> +	/** @multi_queue: snapshot of the multi queue information */
> +	struct {
> +		/**
> +		 * @multi_queue.primary: GuC id of the primary exec queue
> +		 * of the multi queue group.
> +		 */
> +		u32 primary;
> +		/** @multi_queue.pos: Position of the exec queue within the multi queue group */
> +		u8 pos;
> +	} multi_queue;
> +
>  	/** @pending_list_size: Size of the pending list snapshot array */
>  	int pending_list_size;
>  	/** @pending_list: snapshot of the pending list info */
> -- 
> 2.43.0
>