Re: [PATCH v3 2/4] drm/xe/xe_drm_ras: Add support for drm ras

[Raag Jadav <raag.jadav@intel.com>]

On Mon, Jan 12, 2026 at 11:43:16AM +0530, Riana Tauro wrote:
> On 1/9/2026 9:28 PM, Raag Jadav wrote:
> > On Fri, Jan 09, 2026 at 09:13:31AM -0500, Rodrigo Vivi wrote:
> > > On Fri, Jan 09, 2026 at 01:38:44PM +0530, Riana Tauro wrote:
> > > > Hi Raag
> > > > 
> > > > Thank you for the review
> > > > 
> > > > On 12/9/2025 1:52 PM, Raag Jadav wrote:
> > > > > On Fri, Dec 05, 2025 at 02:09:34PM +0530, Riana Tauro wrote:
> > > > > > Allocate correctable, nonfatal and fatal nodes per xe device.
> > > > > > Each node contains error classes, counters and respective
> > > > > > query counter functions.
> > > > > > 
> > > > > > Add basic functionality to create and register drm nodes.
> > > > > > Below operations can be performed using Generic netlink DRM RAS interface

...

> > > > > > +/**
> > > > > > + * enum drm_xe_ras_error_class - Supported drm ras error classes.
> > > > > > + */
> > > > > > +enum drm_xe_ras_error_class {
> > > > > > +	/** @DRM_XE_RAS_ERROR_CORE_COMPUTE: GT and Media Error */
> > > > > > +	DRM_XE_RAS_ERROR_CORE_COMPUTE = 1,
> > > > > > +	/** @DRM_XE_RAS_ERROR_SOC_INTERNAL: SOC Error */
> > > > > > +	DRM_XE_RAS_ERROR_SOC_INTERNAL,
> > > > > > +	/** @DRM_XE_RAS_ERROR_CLASS_MAX: Max Error */
> > > > > > +	DRM_XE_RAS_ERROR_CLASS_MAX,	/* non-ABI */
> > > > > > +};
> > > > > 
> > > > > Also, all of the enums share the same DRM_XE_RAS_ERROR_* prefix, so let's try
> > > > > to have distinguishable naming. Perhaps [*] would be useful here as well ;)
> > > > 
> > > > DRM_XE_RAS_ERROR_SEVERITY_* will cause longer names. Any suggestions?
> > 
> > Already mentioned above[*], the key is to not overuse 'error' ;)
> > 
> > DRM_XE_RAS_SEVERITY_*
> > DRM_XE_RAS_COMPONENT_*
> 
> There's been an interest expressed to add telemetry nodes as well.
> 
> https://patchwork.freedesktop.org/patch/666138/?series=118435&rev=5
> 
> I have kept the prefix (DRM_XE_RAS_ERROR) consistent with the first patch
> (type - ERROR_COUNTER) for alignment.
> 
> From my perspective retaining the prefix ERROR would be beneficial to
> differentiate if there are different types.
> 
> Can you please have a look at the link and let me know if you still think
> the same

Fair, whichever makes sense for the usecase and please excuse my
bikeshedding.

> For differentiation, i will add SEVERITY and CLASS/COMPONENT.

Thank you.

Raag