Re: [PATCH v2 07/12] drm/xe: Rename send_tlb_inval_ppgtt to send_tlb_inval_asid_ppgtt

["Summers, Stuart" <stuart.summers@intel.com>]

On Tue, 2025-11-04 at 11:56 -0800, Matthew Brost wrote:
> Context-based TLB invalidations have their own set of GuC TLB
> invalidation operations. Rename the current PPGTT invalidation
> function,
> which operates on ASIDs, to a more descriptive name that reflects its
> purpose.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
> b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
> index 995789f0d31f..42e9fbd062ba 100644
> --- a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
> +++ b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
> @@ -131,8 +131,8 @@ static u64 normalize_invalidation_range(struct
> xe_gt *gt, u64 *start, u64 *end)
>   */
>  #define MAX_RANGE_TLB_INVALIDATION_LENGTH
> (rounddown_pow_of_two(ULONG_MAX))
>  
> -static int send_tlb_inval_ppgtt(struct xe_tlb_inval *tlb_inval, u32
> seqno,
> -                               u64 start, u64 end, u32 asid)
> +static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval,
> u32 seqno,
> +                                    u64 start, u64 end, u32 asid)
>  {
>  #define MAX_TLB_INVALIDATION_LEN       7
>         struct xe_guc *guc = tlb_inval->private;
> @@ -195,7 +195,7 @@ static long tlb_inval_timeout_delay(struct
> xe_tlb_inval *tlb_inval)
>  static const struct xe_tlb_inval_ops guc_tlb_inval_ops = {
>         .all = send_tlb_inval_all,
>         .ggtt = send_tlb_inval_ggtt,
> -       .ppgtt = send_tlb_inval_ppgtt,
> +       .ppgtt = send_tlb_inval_asid_ppgtt,
>         .initialized = tlb_inval_initialized,
>         .flush = tlb_inval_flush,
>         .timeout_delay = tlb_inval_timeout_delay,