Re: [PATCH v4 5/9] drm/xe: Handle xe_user creation and removal

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 26 Sep 2025, Aakash Deep Sarkar <aakash.deep.sarkar@intel.com> wrote:
> diff --git a/drivers/gpu/drm/xe/xe_user.h b/drivers/gpu/drm/xe/xe_user.h
> index e52f66d3f3b0..b13130cc9492 100644
> --- a/drivers/gpu/drm/xe/xe_user.h
> +++ b/drivers/gpu/drm/xe/xe_user.h
> @@ -8,8 +8,12 @@
>  
>  #include <linux/kref.h>
>  #include <linux/list.h>
> +#include <linux/mutex.h>
>  #include <linux/workqueue.h>
>  
> +#include "xe_device.h"

The changes in this patch don't require adding either of those
includes. Avoid including headers from headers if you can get away with
forward declarations.

BR,
Jani.

> +
> +
>  /**
>   * This is a per process/user id structure for a xe device
>   * client. It is allocated when a new process/app opens the
> @@ -43,6 +47,11 @@ struct xe_user {
>  	 */
>  	struct work_struct work;
>  
> +	/**
> +	 * @id: index of this user into the xe device users array
> +	 */
> +	u32 id;
> +
>  	/**
>  	 * @uid: user id for this xe_user
>  	 */
> @@ -61,7 +70,8 @@ struct xe_user {
>  	u64 last_timestamp_ns;
>  };
>  
> -struct xe_user *xe_user_alloc(void);
> +int xe_user_init(struct xe_device *xe, struct xe_file *xef, unsigned int uid);
> +
>  
>  static inline struct xe_user *
>  xe_user_get(struct xe_user *user)

-- 
Jani Nikula, Intel