Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Aakash Deep Sarkar <aakash.deep.sarkar@intel.com>,
	<intel-xe@lists.freedesktop.org>,  <jeevaka.badrappan@intel.com>,
	<matthew.brost@intel.com>, <carlos.santa@intel.com>,
	<matthew.auld@intel.com>
Subject: Re: [PATCH v4 3/9] drm/xe: Add a trace point for GPU work period
Date: Fri, 03 Oct 2025 14:41:07 -0700	[thread overview]
Message-ID: <87plb3ek98.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <aN6PWaJWCMz2lFsv@intel.com>

On Thu, 02 Oct 2025 07:42:33 -0700, Rodrigo Vivi wrote:
>
> > diff --git a/include/trace/gpu_work_period.h b/include/trace/gpu_work_period.h
> > new file mode 100644
> > index 000000000000..e06467625705
> > --- /dev/null
> > +++ b/include/trace/gpu_work_period.h
> > @@ -0,0 +1,59 @@
> > +/* SPDX-License-Identifier: MIT */
> > +/*
> > + * Copyright © 2025 Intel Corporation
> > + */
> > +
> > +#undef TRACE_SYSTEM
> > +#define TRACE_SYSTEM power
> > +
> > +#if !defined(_TRACE_GPU_WORK_PERIOD_H) || defined(TRACE_HEADER_MULTI_READ)
> > +#define _TRACE_GPU_WORK_PERIOD_H
> > +
> > +#include <linux/tracepoint.h>
> > +
> > +TRACE_EVENT(gpu_work_period,
>
> oh! not again please!
> Stop trying to brute force this.
>
> If it is a xe trace you need to add 'xe_' prefix.
>
> If you really need the 'gpu_' prefix because of Android, this
> needs to go through the drm layer, not a driver specific.

Also, drm layer patches need to be sent to the following mail lists:

	intel-gfx@lists.freedesktop.org
	dri-devel@lists.freedesktop.org
	intel-xe@lists.freedesktop.org

Also, see previous similar comments on the gpu_frequency tracepoint series.

Thanks.
--
Ashutosh

  reply	other threads:[~2025-10-03 21:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 10:45 [PATCH v4 0/9] [ANDROID]: Add GPU work period support for Xe driver Aakash Deep Sarkar
2025-09-26 10:45 ` [PATCH v4 1/9] drm/xe: Add a new xe_user structure Aakash Deep Sarkar
2025-10-02 14:40   ` Rodrigo Vivi
2025-09-26 10:45 ` [PATCH v4 2/9] drm/xe: Add xe_gt_clock_interval_to_ns function Aakash Deep Sarkar
2025-09-26 10:45 ` [PATCH v4 3/9] drm/xe: Add a trace point for GPU work period Aakash Deep Sarkar
2025-10-02 14:42   ` Rodrigo Vivi
2025-10-03 21:41     ` Dixit, Ashutosh [this message]
2025-09-26 10:45 ` [PATCH v4 4/9] drm/xe: Modify xe_exec_queue_update_run_ticks Aakash Deep Sarkar
2025-09-26 10:45 ` [PATCH v4 5/9] drm/xe: Handle xe_user creation and removal Aakash Deep Sarkar
2025-09-26 11:29   ` Jani Nikula
2025-09-26 10:45 ` [PATCH v4 6/9] drm/xe: Implement xe_work_period_worker Aakash Deep Sarkar
2025-09-26 11:31   ` Jani Nikula
2025-09-26 10:45 ` [PATCH v4 7/9] drm/xe: Add a Kconfig option for GPU work period Aakash Deep Sarkar
2025-09-26 10:45 ` [PATCH v4 8/9] drm/xe: Handle xe_work_period destruction Aakash Deep Sarkar
2025-09-26 11:32   ` Jani Nikula
2025-09-26 10:45 ` [PATCH v4 9/9] Hack patch: Do not merge Aakash Deep Sarkar
2025-09-26 11:59 ` ✗ CI.checkpatch: warning for : Add GPU work period support for Xe driver (rev4) Patchwork
2025-09-26 12:01 ` ✓ CI.KUnit: success " Patchwork
2025-09-26 12:51 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-09-26 18:04 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plb3ek98.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=aakash.deep.sarkar@intel.com \
    --cc=carlos.santa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jeevaka.badrappan@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox