Re: [PATCH v4 8/9] drm/xe: Handle xe_work_period destruction

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 26 Sep 2025, Aakash Deep Sarkar <aakash.deep.sarkar@intel.com> wrote:
> This adds the xe_work_period destruction procedure.
> We iterate over all entries in the xe::work_period::users
> xarray and cancel any pending delayed work. Then destroy
> the xarray itself.
>
> Signed-off-by: Aakash Deep Sarkar <aakash.deep.sarkar@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index c34da72e5c9a..e270f57a9750 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -419,6 +419,8 @@ static struct drm_driver driver = {
>  static void xe_device_destroy(struct drm_device *dev, void *dummy)
>  {
>  	struct xe_device *xe = to_xe_device(dev);
> +	struct xe_user *user = NULL;
> +	unsigned long i;
>  
>  	xe_bo_dev_fini(&xe->bo_device);
>  
> @@ -434,6 +436,15 @@ static void xe_device_destroy(struct drm_device *dev, void *dummy)
>  	if (xe->destroy_wq)
>  		destroy_workqueue(xe->destroy_wq);
>  
> +
> +	mutex_lock(&xe->work_period.lock);
> +	xa_for_each(&xe->work_period.users, i, user) {
> +		if (cancel_delayed_work_sync(&user->delay_work))
> +			xe_user_put(user);
> +	}
> +	xa_destroy(&xe->work_period.users);
> +	mutex_unlock(&xe->work_period.lock);

These are all user details, why are they in xe_device_destroy()? Add a
new function that does this for you, and hide all the details away.

BR,
Jani.

> +
>  	ttm_device_fini(&xe->ttm);
>  }

-- 
Jani Nikula, Intel