Re: [PATCH v2 29/34] drm/xe/kunit: Build DP link display tests

[Imre Deak <imre.deak@intel.com>]

On Sat, Jul 04, 2026 at 12:49:49PM +0200, Michał Grzelak wrote:
> On Wed, 1 Jul 2026, Imre Deak wrote:
> > Hook the shared i915 display DP link KUnit tests into the xe display
> > test build.
> > 
> > Build the shared display test source from the i915 display test directory
> > when xe display support is enabled.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> > drivers/gpu/drm/xe/Makefile               |  3 +++
> > drivers/gpu/drm/xe/display/tests/Makefile | 11 +++++++++++
> > 2 files changed, 14 insertions(+)
> > create mode 100644 drivers/gpu/drm/xe/display/tests/Makefile
> > 
> > diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> > index e5a04253e73bf..3ff58186c7678 100644
> > --- a/drivers/gpu/drm/xe/Makefile
> > +++ b/drivers/gpu/drm/xe/Makefile
> > @@ -373,6 +373,9 @@ xe-$(CONFIG_DRM_XE_DP_TUNNEL) += \
> > 
> > obj-$(CONFIG_DRM_XE) += xe.o
> > obj-$(CONFIG_DRM_XE_KUNIT_TEST) += tests/
> > +ifeq ($(CONFIG_DRM_XE_DISPLAY),y)
> > +	obj-$(CONFIG_DRM_XE_KUNIT_TEST) += display/tests/
> > +endif
> > 
> > # header test
> > hdrtest_find_args := -not -path xe_rtp_helpers.h
> > diff --git a/drivers/gpu/drm/xe/display/tests/Makefile b/drivers/gpu/drm/xe/display/tests/Makefile
> > new file mode 100644
> > index 0000000000000..1a582febe17a6
> > --- /dev/null
> > +++ b/drivers/gpu/drm/xe/display/tests/Makefile
> > @@ -0,0 +1,11 @@
> 
> Not sure but I think # SPDX ... boilterplate is missing.

Yes, thanks for catching that, will add it.

> Otherwise or if does not apply:
> 
> Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>
> 
> BR,
> Michał
> 
> > +subdir-ccflags-$(CONFIG_DRM_XE_DISPLAY) += \
> > +	-I$(srctree)/drivers/gpu/drm/i915/display/
> > +
> > +# Rule to build display code shared with i915
> > +$(obj)/i915-display/tests/%.o: $(srctree)/drivers/gpu/drm/i915/display/tests/%.c FORCE
> > +	$(call cmd,force_checksrc)
> > +	$(call if_changed_rule,cc_o_c)
> > +
> > +obj-$(CONFIG_DRM_XE_KUNIT_TEST) += xe_display_test.o
> > +xe_display_test-y = \
> > +		i915-display/tests/intel_dp_link_test.o
> > -- 
> > 2.49.1
> > 
> >