public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/xe_survivability: Fix runtime survivability error handling
@ 2026-04-14 12:44 Mallesh Koujalagi
  2026-04-14 12:54 ` ✓ CI.KUnit: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Mallesh Koujalagi @ 2026-04-14 12:44 UTC (permalink / raw)
  To: intel-xe, rodrigo.vivi, matthew.brost
  Cc: anshuman.gupta, badal.nilawar, riana.tauro, karthik.poosa,
	sk.anirban, raag.jadav, Mallesh Koujalagi

When enabling survivability mode at runtime, the code tries to create
a sysfs entry. If that step fails, the error is only logged, but the
function still reports success. This makes it look like survivability
mode was enabled even though part of it failed.

Fixes: a2ca0633a0fe ("drm/xe/xe_survivability: Add support for Runtime survivability mode")
Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
---
 drivers/gpu/drm/xe/xe_survivability_mode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
index db64cac39c94..c2dfc7ea7b83 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.c
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
@@ -413,8 +413,10 @@ int xe_survivability_mode_runtime_enable(struct xe_device *xe)
 	populate_survivability_info(xe);
 
 	ret = create_survivability_sysfs(pdev);
-	if (ret)
+	if (ret) {
 		dev_err(&pdev->dev, "Failed to create survivability mode sysfs\n");
+		return ret;
+	}
 
 	survivability->type = XE_SURVIVABILITY_TYPE_RUNTIME;
 	dev_err(&pdev->dev, "Runtime Survivability mode enabled\n");
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-04-14 14:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-14 12:44 [PATCH] drm/xe/xe_survivability: Fix runtime survivability error handling Mallesh Koujalagi
2026-04-14 12:54 ` ✓ CI.KUnit: success for " Patchwork
2026-04-14 13:58 ` [PATCH] " Rodrigo Vivi
2026-04-14 14:11   ` Raag Jadav
2026-04-14 14:35     ` Tauro, Riana
2026-04-14 14:00 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-04-14 14:55 ` ✗ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox