Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken
@ 2024-10-11 15:10 Nirmoy Das
  2024-10-11 19:54 ` ✓ CI.Patch_applied: success for drm/xe/ufence: ufence can be signaled right after wait_woken (rev2) Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Nirmoy Das @ 2024-10-11 15:10 UTC (permalink / raw)
  To: intel-xe
  Cc: Nirmoy Das, stable, Bommu Krishnaiah, Matthew Auld, Matthew Brost

do_comapre() can return success after a timedout wait_woken() which was
treated as -ETIME. The loop calling wait_woken() sets correct err so
there is no need to re-evaluate err.

v2: Remove entire check that reevaluate err at the end(Matt)

Fixes: e670f0b4ef24 ("drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl")
Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630
Cc: <stable@vger.kernel.org> # v6.8+
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_wait_user_fence.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c
index d46fa8374980..f5deb81eba01 100644
--- a/drivers/gpu/drm/xe/xe_wait_user_fence.c
+++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c
@@ -169,9 +169,6 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data,
 			args->timeout = 0;
 	}
 
-	if (!timeout && !(err < 0))
-		err = -ETIME;
-
 	if (q)
 		xe_exec_queue_put(q);
 
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-10-14  8:06 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-11 15:10 [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken Nirmoy Das
2024-10-11 19:54 ` ✓ CI.Patch_applied: success for drm/xe/ufence: ufence can be signaled right after wait_woken (rev2) Patchwork
2024-10-11 19:54 ` ✓ CI.checkpatch: " Patchwork
2024-10-11 19:56 ` ✓ CI.KUnit: " Patchwork
2024-10-11 20:11 ` ✓ CI.Build: " Patchwork
2024-10-11 20:13 ` ✓ CI.Hooks: " Patchwork
2024-10-11 20:15 ` ✓ CI.checksparse: " Patchwork
2024-10-12  2:07 ` [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken Matthew Brost
2024-10-12  2:35 ` ✗ CI.FULL: failure for drm/xe/ufence: ufence can be signaled right after wait_woken (rev2) Patchwork
2024-10-14  8:06   ` Nirmoy Das
2024-10-14  7:53 ` [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken Matthew Auld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox