From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v3 03/13] auto-t: only call set_value for changed values in default()
Date: Wed, 6 Dec 2023 12:17:52 -0800 [thread overview]
Message-ID: <20231206201802.2139649-3-prestwoj@gmail.com> (raw)
In-Reply-To: <20231206201802.2139649-1-prestwoj@gmail.com>
The default() method was added for convenience but was extending the
test times significantly when the hostapd config was lengthy. This
was because it called set_value for every value regardless if it
had changed. Instead store the current configuration and in default()
only reset values that differ.
---
autotests/util/hostapd.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/autotests/util/hostapd.py b/autotests/util/hostapd.py
index 1b1bc399..cee08092 100644
--- a/autotests/util/hostapd.py
+++ b/autotests/util/hostapd.py
@@ -75,6 +75,8 @@ class HostapdCLI(object):
if self._default_config.get('vendor_elements', None) == None:
self._default_config['vendor_elements'] = ''
+ self._current_config = self._default_config.copy()
+
if not self.interface:
raise Exception('config %s not found' % config)
@@ -170,6 +172,8 @@ class HostapdCLI(object):
if self._default_config.get(key, None) == None:
raise Exception("Untracked setting '%s'! Please set default in hostapd config" % key)
+ self._current_config[key] = value
+
cmd = self.cmdline + ['set', key, value]
ctx.start_process(cmd).wait()
@@ -200,7 +204,10 @@ class HostapdCLI(object):
def default(self):
for k, v in self._default_config.items():
- self.set_value(k, v)
+ # Only bother setting the value if it differs
+ if self._current_config[k] != v:
+ self.set_value(k, v)
+ self._current_config[k] = v
self.reload()
--
2.34.1
next prev parent reply other threads:[~2023-12-06 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 20:17 [PATCH v3 01/13] auto-t: add explicit stop() to IWD class James Prestwood
2023-12-06 20:17 ` [PATCH v3 02/13] auto-t: add association timeout test James Prestwood
2023-12-06 20:17 ` James Prestwood [this message]
2023-12-06 20:17 ` [PATCH v3 04/13] handshake: add setters for authenticator/supplicant_fte James Prestwood
2023-12-06 20:17 ` [PATCH v3 05/13] handshake: use authenticator_fte instead of 'fte' James Prestwood
2023-12-06 20:17 ` [PATCH v3 06/13] unit: use authenticator_fte James Prestwood
2023-12-06 20:17 ` [PATCH v3 07/13] handshake: remove handshake_state_set_fte James Prestwood
2023-12-06 20:17 ` [PATCH v3 08/13] ft: add FTE/RSNE building to ft_prepare_handshake James Prestwood
2023-12-06 20:17 ` [PATCH v3 09/13] ft: add ft_handshake_setup James Prestwood
2023-12-06 20:17 ` [PATCH v3 10/13] netdev: add netdev_ft_reassociate James Prestwood
2023-12-06 20:18 ` [PATCH v3 11/13] station: use netdev_ft_reassociate James Prestwood
2023-12-06 20:18 ` [PATCH v3 12/13] ft: remove ft_associate and helpers James Prestwood
2023-12-06 20:18 ` [PATCH v3 13/13] netdev: station: remove NETDEV_EVENT_FT_ROAMED James Prestwood
2023-12-13 16:14 ` [PATCH v3 01/13] auto-t: add explicit stop() to IWD class Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206201802.2139649-3-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox