* [patch] ASoC: wm8904: harmless underflow in wm8904_put_deemph()
@ 2015-10-13 7:08 Dan Carpenter
2015-10-13 12:27 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-10-13 7:08 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Charles Keepax,
Lars-Peter Clausen, Bo Shen, Alexander Morozov,
Krzysztof Kozlowski, Fabio Estevam, patches, alsa-devel,
kernel-janitors
We try to check that "deemph" is zero or one, but because of an
underflow bug, it can also be negative. It's fine, negative values are
handled as non-zero. But it's messy and static checkers complain so
let's fix it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index b783743..2aa23f1 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -534,7 +534,7 @@ static int wm8904_put_deemph(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
- int deemph = ucontrol->value.integer.value[0];
+ unsigned int deemph = ucontrol->value.integer.value[0];
if (deemph > 1)
return -EINVAL;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] ASoC: wm8904: harmless underflow in wm8904_put_deemph()
2015-10-13 7:08 [patch] ASoC: wm8904: harmless underflow in wm8904_put_deemph() Dan Carpenter
@ 2015-10-13 12:27 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2015-10-13 12:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Fabio Estevam, Krzysztof Kozlowski, Lars-Peter Clausen,
alsa-devel, patches, kernel-janitors, Takashi Iwai, Liam Girdwood,
Alexander Morozov, Mark Brown, Bo Shen
On Tue, Oct 13, 2015 at 10:08:18AM +0300, Dan Carpenter wrote:
> We try to check that "deemph" is zero or one, but because of an
> underflow bug, it can also be negative. It's fine, negative values are
> handled as non-zero. But it's messy and static checkers complain so
> let's fix it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-13 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 7:08 [patch] ASoC: wm8904: harmless underflow in wm8904_put_deemph() Dan Carpenter
2015-10-13 12:27 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox