* [PATCH] ppc64: erase unnecessary segment info printing
@ 2014-10-29 8:19 Baoquan He
2015-02-02 3:31 ` Baoquan He
2015-02-09 5:55 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Baoquan He @ 2014-10-29 8:19 UTC (permalink / raw)
To: kexec; +Cc: horms, Baoquan He
In ppc64 loading, it will print the segment information. This is not
wanted since other Archs don't have this. People even think there's
something wrong. So erase it to make it be consistent with other Archs.
And if people really want to check these info, they can specify "-d"
option. They are printed in print_segments() too.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kexec/arch/ppc64/kexec-elf-ppc64.c b/kexec/arch/ppc64/kexec-elf-ppc64.c
index ce10367..4a1540e 100644
--- a/kexec/arch/ppc64/kexec-elf-ppc64.c
+++ b/kexec/arch/ppc64/kexec-elf-ppc64.c
@@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,
dbgprintf("opal_base is %llx\n", (unsigned long long) my_opal_base);
dbgprintf("opal_entry is %llx\n", (unsigned long long) my_opal_entry);
- for (i = 0; i < info->nr_segments; i++)
- fprintf(stderr, "segment[%d].mem:%p memsz:%zu\n", i,
- info->segment[i].mem, info->segment[i].memsz);
-
return 0;
}
--
1.9.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ppc64: erase unnecessary segment info printing
2014-10-29 8:19 [PATCH] ppc64: erase unnecessary segment info printing Baoquan He
@ 2015-02-02 3:31 ` Baoquan He
2015-02-09 5:55 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Baoquan He @ 2015-02-02 3:31 UTC (permalink / raw)
To: kexec; +Cc: horms
Hi Simon,
ping.
Could you please have a look at this patch and merge it if you think
it's OK?
Thanks
Baoquan
On 10/29/14 at 04:19pm, Baoquan He wrote:
> In ppc64 loading, it will print the segment information. This is not
> wanted since other Archs don't have this. People even think there's
> something wrong. So erase it to make it be consistent with other Archs.
>
> And if people really want to check these info, they can specify "-d"
> option. They are printed in print_segments() too.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kexec/arch/ppc64/kexec-elf-ppc64.c b/kexec/arch/ppc64/kexec-elf-ppc64.c
> index ce10367..4a1540e 100644
> --- a/kexec/arch/ppc64/kexec-elf-ppc64.c
> +++ b/kexec/arch/ppc64/kexec-elf-ppc64.c
> @@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,
> dbgprintf("opal_base is %llx\n", (unsigned long long) my_opal_base);
> dbgprintf("opal_entry is %llx\n", (unsigned long long) my_opal_entry);
>
> - for (i = 0; i < info->nr_segments; i++)
> - fprintf(stderr, "segment[%d].mem:%p memsz:%zu\n", i,
> - info->segment[i].mem, info->segment[i].memsz);
> -
> return 0;
> }
>
> --
> 1.9.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ppc64: erase unnecessary segment info printing
2014-10-29 8:19 [PATCH] ppc64: erase unnecessary segment info printing Baoquan He
2015-02-02 3:31 ` Baoquan He
@ 2015-02-09 5:55 ` Simon Horman
2015-02-09 6:03 ` Baoquan He
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2015-02-09 5:55 UTC (permalink / raw)
To: Baoquan He; +Cc: kexec
On Wed, Oct 29, 2014 at 04:19:55PM +0800, Baoquan He wrote:
> In ppc64 loading, it will print the segment information. This is not
> wanted since other Archs don't have this. People even think there's
> something wrong. So erase it to make it be consistent with other Archs.
>
> And if people really want to check these info, they can specify "-d"
> option. They are printed in print_segments() too.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
Thanks, applied.
> ---
> kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kexec/arch/ppc64/kexec-elf-ppc64.c b/kexec/arch/ppc64/kexec-elf-ppc64.c
> index ce10367..4a1540e 100644
> --- a/kexec/arch/ppc64/kexec-elf-ppc64.c
> +++ b/kexec/arch/ppc64/kexec-elf-ppc64.c
> @@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,
> dbgprintf("opal_base is %llx\n", (unsigned long long) my_opal_base);
> dbgprintf("opal_entry is %llx\n", (unsigned long long) my_opal_entry);
>
> - for (i = 0; i < info->nr_segments; i++)
> - fprintf(stderr, "segment[%d].mem:%p memsz:%zu\n", i,
> - info->segment[i].mem, info->segment[i].memsz);
> -
> return 0;
> }
>
> --
> 1.9.0
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ppc64: erase unnecessary segment info printing
2015-02-09 5:55 ` Simon Horman
@ 2015-02-09 6:03 ` Baoquan He
0 siblings, 0 replies; 4+ messages in thread
From: Baoquan He @ 2015-02-09 6:03 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec
On 02/09/15 at 02:55pm, Simon Horman wrote:
> On Wed, Oct 29, 2014 at 04:19:55PM +0800, Baoquan He wrote:
> > In ppc64 loading, it will print the segment information. This is not
> > wanted since other Archs don't have this. People even think there's
> > something wrong. So erase it to make it be consistent with other Archs.
> >
> > And if people really want to check these info, they can specify "-d"
> > option. They are printed in print_segments() too.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
> Thanks, applied.
Thanks, Simon.
>
> > ---
> > kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/kexec/arch/ppc64/kexec-elf-ppc64.c b/kexec/arch/ppc64/kexec-elf-ppc64.c
> > index ce10367..4a1540e 100644
> > --- a/kexec/arch/ppc64/kexec-elf-ppc64.c
> > +++ b/kexec/arch/ppc64/kexec-elf-ppc64.c
> > @@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,
> > dbgprintf("opal_base is %llx\n", (unsigned long long) my_opal_base);
> > dbgprintf("opal_entry is %llx\n", (unsigned long long) my_opal_entry);
> >
> > - for (i = 0; i < info->nr_segments; i++)
> > - fprintf(stderr, "segment[%d].mem:%p memsz:%zu\n", i,
> > - info->segment[i].mem, info->segment[i].memsz);
> > -
> > return 0;
> > }
> >
> > --
> > 1.9.0
> >
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-09 6:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-29 8:19 [PATCH] ppc64: erase unnecessary segment info printing Baoquan He
2015-02-02 3:31 ` Baoquan He
2015-02-09 5:55 ` Simon Horman
2015-02-09 6:03 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox