From: Pekka Enberg <penberg@kernel.org>
To: Asias He <asias.hejun@gmail.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
gorcunov@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] kvm tools: Set up tun interface using ioctls
Date: Wed, 13 Apr 2011 17:03:16 +0300 [thread overview]
Message-ID: <1302703396.15231.24.camel@jaguar> (raw)
In-Reply-To: <4DA5AC37.1030602@gmail.com>
On Wed, 2011-04-13 at 21:59 +0800, Asias He wrote:
> On 04/13/2011 09:49 PM, Pekka Enberg wrote:
> > On Wed, 13 Apr 2011, Sasha Levin wrote:
> >> Use ioctls to assign IP address and bring interface up instead of
> >> using ifconfig.
> >>
> >> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> >
> > I'm seeing this:
> >
> > penberg@tiger:~/linux/tools/kvm$ make
> > GEN include/common-cmds.h
> > CC 8250-serial.o
> > CC virtio-blk.o
> > CC virtio-net.o
> > cc1: warnings being treated as errors
> > virtio-net.c: In function ‘virtio_net__init’:
> > virtio-net.c:302: error: dereferencing pointer ‘({anonymous})’ does
> > break strict-aliasing rules
> > virtio-net.c:302: note: initialized from here
> > make: *** [virtio-net.o] Error 1
>
> Hi, Pekka
>
> I am wondering why is your gcc always stricter than mine?
I have gcc 4.4.3 here. I wouldn't be surprised if those were actually
gcc bugs but and that we should turn off the aliasing checks. However,
for this particular case, it was pretty good at spotting questionable
code so... :-)
Pekka
prev parent reply other threads:[~2011-04-13 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 12:13 [PATCH 1/2] kvm tools: Set up tun interface using ioctls Sasha Levin
2011-04-13 12:13 ` [PATCH 2/2] kvm tools: Make host side IP configurable Sasha Levin
2011-04-13 12:28 ` Asias He
2011-04-13 12:35 ` Pekka Enberg
2011-04-13 13:28 ` Asias He
2011-04-13 13:38 ` Sasha Levin
2011-04-13 14:07 ` Pekka Enberg
2011-04-13 14:13 ` Asias He
2011-04-13 12:39 ` [PATCH 1/2] kvm tools: Set up tun interface using ioctls Asias He
2011-04-13 13:49 ` Pekka Enberg
2011-04-13 13:59 ` Asias He
2011-04-13 14:03 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302703396.15231.24.camel@jaguar \
--to=penberg@kernel.org \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox