From: Pekka Enberg <penberg@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Asias He <asias.hejun@gmail.com>,
gorcunov@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] kvm tools: Make host side IP configurable
Date: Wed, 13 Apr 2011 17:07:25 +0300 [thread overview]
Message-ID: <1302703645.15231.26.camel@jaguar> (raw)
In-Reply-To: <BANLkTimuFzZaih8GEdDv0HmJpQ6tt18fAg@mail.gmail.com>
On Wed, 2011-04-13 at 16:38 +0300, Sasha Levin wrote:
> On Wed, Apr 13, 2011 at 4:28 PM, Asias He <asias.hejun@gmail.com> wrote:
> > On 04/13/2011 08:28 PM, Asias He wrote:
> >> On 04/13/2011 08:13 PM, Sasha Levin wrote:
> >>> Add --host-ip-addr parameter to allow changing the host-side IP address.
> >>
> >>
> >> I'd personally prefer something like this:
> >>
> >> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy
> >>
> >> Once we can set up ip address for guest, we can use:
> >>
> >> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy,guestip=z.z.z.z/mask,guestgw=v.v.v.v
> >>
> >
> >
> > Alternatively, we can use an option group like this:
> >
> > Network options:
> > -n --network <virtio>
> > -h --hostip <x.x.x.x/n>
> > -y --guestip <x.x.x.x/n>
> > -z --guestmac <xx:xx:xx:xx:xx:xx>
> >
>
> I agree. We can create a networking group once we start expanding the options.
Asias, is the patch OK to merge?
next prev parent reply other threads:[~2011-04-13 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 12:13 [PATCH 1/2] kvm tools: Set up tun interface using ioctls Sasha Levin
2011-04-13 12:13 ` [PATCH 2/2] kvm tools: Make host side IP configurable Sasha Levin
2011-04-13 12:28 ` Asias He
2011-04-13 12:35 ` Pekka Enberg
2011-04-13 13:28 ` Asias He
2011-04-13 13:38 ` Sasha Levin
2011-04-13 14:07 ` Pekka Enberg [this message]
2011-04-13 14:13 ` Asias He
2011-04-13 12:39 ` [PATCH 1/2] kvm tools: Set up tun interface using ioctls Asias He
2011-04-13 13:49 ` Pekka Enberg
2011-04-13 13:59 ` Asias He
2011-04-13 14:03 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302703645.15231.26.camel@jaguar \
--to=penberg@kernel.org \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox