From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Asias He <asias.hejun@gmail.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
gorcunov@gmail.com, kvm@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH 2/2] kvm tools: Make host side IP configurable
Date: Wed, 13 Apr 2011 15:35:24 +0300 [thread overview]
Message-ID: <4DA5988C.50908@cs.helsinki.fi> (raw)
In-Reply-To: <4DA59704.8@gmail.com>
On 4/13/11 3:28 PM, Asias He wrote:
> On 04/13/2011 08:13 PM, Sasha Levin wrote:
>> Add --host-ip-addr parameter to allow changing the host-side IP address.
>
> I'd personally prefer something like this:
>
> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy
>
> Once we can set up ip address for guest, we can use:
>
> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy,guestip=z.z.z.z/mask,guestgw=v.v.v.v
What's the benefit over
--network=virtio --hostip=x.x.x.x/mask --guestmac= [...]
form? Isn't Sasha's form a much better fit with the git-like front end
(for parsing and help text)?
Pekka
next prev parent reply other threads:[~2011-04-13 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 12:13 [PATCH 1/2] kvm tools: Set up tun interface using ioctls Sasha Levin
2011-04-13 12:13 ` [PATCH 2/2] kvm tools: Make host side IP configurable Sasha Levin
2011-04-13 12:28 ` Asias He
2011-04-13 12:35 ` Pekka Enberg [this message]
2011-04-13 13:28 ` Asias He
2011-04-13 13:38 ` Sasha Levin
2011-04-13 14:07 ` Pekka Enberg
2011-04-13 14:13 ` Asias He
2011-04-13 12:39 ` [PATCH 1/2] kvm tools: Set up tun interface using ioctls Asias He
2011-04-13 13:49 ` Pekka Enberg
2011-04-13 13:59 ` Asias He
2011-04-13 14:03 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA5988C.50908@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox