public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
	david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com,
	scgl@linux.ibm.com
Subject: [kvm-unit-tests PATCH v3 1/9] s390x: uv: Tolerate 0x100 query return code
Date: Thu,  7 Oct 2021 08:50:19 +0000	[thread overview]
Message-ID: <20211007085027.13050-2-frankja@linux.ibm.com> (raw)
In-Reply-To: <20211007085027.13050-1-frankja@linux.ibm.com>

RC 0x100 is not an error but a notice that we could have gotten more
data from the Ultravisor if we had asked for it. So let's tolerate
them in our tests.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 s390x/uv-guest.c | 4 +++-
 s390x/uv-host.c  | 8 +++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/s390x/uv-guest.c b/s390x/uv-guest.c
index f05ae4c3..44ad2154 100644
--- a/s390x/uv-guest.c
+++ b/s390x/uv-guest.c
@@ -71,7 +71,9 @@ static void test_query(void)
 
 	uvcb.header.len = sizeof(uvcb);
 	cc = uv_call(0, (u64)&uvcb);
-	report(cc == 0 && uvcb.header.rc == UVC_RC_EXECUTED, "successful query");
+	report((!cc && uvcb.header.rc == UVC_RC_EXECUTED) ||
+	       (cc == 1 && uvcb.header.rc == 0x100),
+		"successful query");
 
 	/*
 	 * These bits have been introduced with the very first
diff --git a/s390x/uv-host.c b/s390x/uv-host.c
index 28035707..4b72c24d 100644
--- a/s390x/uv-host.c
+++ b/s390x/uv-host.c
@@ -385,7 +385,7 @@ static void test_init(void)
 
 static void test_query(void)
 {
-	int i = 0;
+	int i = 0, cc;
 
 	uvcb_qui.header.cmd = UVC_CMD_QUI;
 	uvcb_qui.header.len = sizeof(uvcb_qui);
@@ -400,8 +400,10 @@ static void test_query(void)
 	report(uvcb_qui.header.rc == 0x100, "insf length");
 
 	uvcb_qui.header.len = sizeof(uvcb_qui);
-	uv_call(0, (uint64_t)&uvcb_qui);
-	report(uvcb_qui.header.rc == UVC_RC_EXECUTED, "successful query");
+	cc = uv_call(0, (uint64_t)&uvcb_qui);
+	report((!cc && uvcb_qui.header.rc == UVC_RC_EXECUTED) ||
+	       (cc == 1 && uvcb_qui.header.rc == 0x100),
+		"successful query");
 
 	for (i = 0; cmds[i].name; i++)
 		report(uv_query_test_call(cmds[i].call_bit), "%s", cmds[i].name);
-- 
2.30.2


  reply	other threads:[~2021-10-07  8:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07  8:50 [kvm-unit-tests PATCH v3 0/9] s390x: Cleanup and maintenance 2 Janosch Frank
2021-10-07  8:50 ` Janosch Frank [this message]
2021-10-07  8:58   ` [kvm-unit-tests PATCH v3 1/9] s390x: uv: Tolerate 0x100 query return code Thomas Huth
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 2/9] s390x: uv-host: Fence a destroy cpu test on z15 Janosch Frank
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 3/9] lib: s390x: uv: Fix share return value and print Janosch Frank
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 4/9] lib: s390x: uv: Add UVC_ERR_DEBUG switch Janosch Frank
2021-10-07  9:01   ` Thomas Huth
2021-10-13 14:14   ` Janosch Frank
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 5/9] lib: s390x: Add access key argument to tprot Janosch Frank
2021-10-07  9:05   ` Thomas Huth
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 6/9] lib: s390x: Print PGM code as hex Janosch Frank
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 7/9] s390x: Add sthyi cc==0 r2+1 verification Janosch Frank
2021-10-07  9:11   ` Thomas Huth
2021-10-07 10:51     ` Janosch Frank
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 8/9] s390x: snippets: Set stackptr and stacktop in cstart.S Janosch Frank
2021-10-07  9:13   ` Thomas Huth
2021-10-07  9:22     ` Janosch Frank
2021-10-07  8:50 ` [kvm-unit-tests PATCH v3 9/9] s390x: snippets: Define all things that are needed to link the lib Janosch Frank
2021-10-07  9:44   ` Thomas Huth
2021-10-07 10:44     ` Janosch Frank
2021-10-08  7:20       ` Thomas Huth
2021-10-08  8:13         ` Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211007085027.13050-2-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=scgl@linux.ibm.com \
    --cc=seiden@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox