From: Janosch Frank <frankja@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, seiden@linux.ibm.com, scgl@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v3 8/9] s390x: snippets: Set stackptr and stacktop in cstart.S
Date: Thu, 7 Oct 2021 11:22:38 +0200 [thread overview]
Message-ID: <2119bbdd-3533-1995-9a68-0c772ec583d2@linux.ibm.com> (raw)
In-Reply-To: <39c39816-146e-6715-fe22-0f56bd943d6f@redhat.com>
On 10/7/21 11:13, Thomas Huth wrote:
> On 07/10/2021 10.50, Janosch Frank wrote:
>> We have a stack, so why not define it and be a step closer to include
>> the lib into the snippets.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> s390x/snippets/c/cstart.S | 2 +-
>> s390x/snippets/c/flat.lds | 2 ++
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/s390x/snippets/c/cstart.S b/s390x/snippets/c/cstart.S
>> index a1754808..031a6b83 100644
>> --- a/s390x/snippets/c/cstart.S
>> +++ b/s390x/snippets/c/cstart.S
>> @@ -17,7 +17,7 @@ start:
>> xgr \i,\i
>> .endr
>> /* 0x3000 is the stack page for now */
>> - lghi %r15, 0x4000 - 160
>> + lghi %r15, stackptr
>
> I already wanted to ask you to replace the magic value 0x4000 here ... great
> to see that you already did it :-)
Magic mind reading :-)
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Thanks!
next prev parent reply other threads:[~2021-10-07 9:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 8:50 [kvm-unit-tests PATCH v3 0/9] s390x: Cleanup and maintenance 2 Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 1/9] s390x: uv: Tolerate 0x100 query return code Janosch Frank
2021-10-07 8:58 ` Thomas Huth
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 2/9] s390x: uv-host: Fence a destroy cpu test on z15 Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 3/9] lib: s390x: uv: Fix share return value and print Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 4/9] lib: s390x: uv: Add UVC_ERR_DEBUG switch Janosch Frank
2021-10-07 9:01 ` Thomas Huth
2021-10-13 14:14 ` Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 5/9] lib: s390x: Add access key argument to tprot Janosch Frank
2021-10-07 9:05 ` Thomas Huth
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 6/9] lib: s390x: Print PGM code as hex Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 7/9] s390x: Add sthyi cc==0 r2+1 verification Janosch Frank
2021-10-07 9:11 ` Thomas Huth
2021-10-07 10:51 ` Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 8/9] s390x: snippets: Set stackptr and stacktop in cstart.S Janosch Frank
2021-10-07 9:13 ` Thomas Huth
2021-10-07 9:22 ` Janosch Frank [this message]
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 9/9] s390x: snippets: Define all things that are needed to link the lib Janosch Frank
2021-10-07 9:44 ` Thomas Huth
2021-10-07 10:44 ` Janosch Frank
2021-10-08 7:20 ` Thomas Huth
2021-10-08 8:13 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2119bbdd-3533-1995-9a68-0c772ec583d2@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=scgl@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox