From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com,
scgl@linux.ibm.com
Subject: [kvm-unit-tests PATCH v3 3/9] lib: s390x: uv: Fix share return value and print
Date: Thu, 7 Oct 2021 08:50:21 +0000 [thread overview]
Message-ID: <20211007085027.13050-4-frankja@linux.ibm.com> (raw)
In-Reply-To: <20211007085027.13050-1-frankja@linux.ibm.com>
Let's only return 0/1 for success/failure respectively.
If needed we can later add rc/rrc pointers so we can check for the
reasons of cc==1 cases like we do in the kernel.
As share() might also be used in snippets it's best not to use prints
to avoid linking problems so lets remove the report_info().
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Acked-by: Thomas Huth <thuth@redhat.com>
---
lib/s390x/asm/uv.h | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
index ec10d1c4..2f099553 100644
--- a/lib/s390x/asm/uv.h
+++ b/lib/s390x/asm/uv.h
@@ -219,15 +219,8 @@ static inline int share(unsigned long addr, u16 cmd)
.header.len = sizeof(uvcb),
.paddr = addr
};
- int cc;
- cc = uv_call(0, (u64)&uvcb);
- if (!cc && uvcb.header.rc == UVC_RC_EXECUTED)
- return 0;
-
- report_info("uv_call: cmd %04x cc %d response code: %04x", cc, cmd,
- uvcb.header.rc);
- return -1;
+ return uv_call(0, (u64)&uvcb);
}
/*
--
2.30.2
next prev parent reply other threads:[~2021-10-07 8:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 8:50 [kvm-unit-tests PATCH v3 0/9] s390x: Cleanup and maintenance 2 Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 1/9] s390x: uv: Tolerate 0x100 query return code Janosch Frank
2021-10-07 8:58 ` Thomas Huth
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 2/9] s390x: uv-host: Fence a destroy cpu test on z15 Janosch Frank
2021-10-07 8:50 ` Janosch Frank [this message]
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 4/9] lib: s390x: uv: Add UVC_ERR_DEBUG switch Janosch Frank
2021-10-07 9:01 ` Thomas Huth
2021-10-13 14:14 ` Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 5/9] lib: s390x: Add access key argument to tprot Janosch Frank
2021-10-07 9:05 ` Thomas Huth
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 6/9] lib: s390x: Print PGM code as hex Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 7/9] s390x: Add sthyi cc==0 r2+1 verification Janosch Frank
2021-10-07 9:11 ` Thomas Huth
2021-10-07 10:51 ` Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 8/9] s390x: snippets: Set stackptr and stacktop in cstart.S Janosch Frank
2021-10-07 9:13 ` Thomas Huth
2021-10-07 9:22 ` Janosch Frank
2021-10-07 8:50 ` [kvm-unit-tests PATCH v3 9/9] s390x: snippets: Define all things that are needed to link the lib Janosch Frank
2021-10-07 9:44 ` Thomas Huth
2021-10-07 10:44 ` Janosch Frank
2021-10-08 7:20 ` Thomas Huth
2021-10-08 8:13 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007085027.13050-4-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=scgl@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox