Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Nikos Nikoleris <nikos.nikoleris@arm.com>
To: kvm@vger.kernel.org, kvmarm@lists.linux.dev, andrew.jones@linux.dev
Cc: pbonzini@redhat.com, alexandru.elisei@arm.com,
	ricarkol@google.com, Andrew Jones <drjones@redhat.com>
Subject: [kvm-unit-tests PATCH v5 11/29] arm64: Add support for setting up the PSCI conduit through ACPI
Date: Fri, 28 Apr 2023 13:03:47 +0100	[thread overview]
Message-ID: <20230428120405.3770496-12-nikos.nikoleris@arm.com> (raw)
In-Reply-To: <20230428120405.3770496-1-nikos.nikoleris@arm.com>

In systems with ACPI support and when a DT is not provided, we can use
the FADT to discover whether PSCI calls need to use smc or hvc
calls. This change implements this but retains the default behavior;
we check if a valid DT is provided, if not, we try to setup the PSCI
conduit using ACPI.

Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Ricardo Koller <ricarkol@google.com>
---
 arm/Makefile.arm64 |  4 ++++
 lib/acpi.h         |  5 +++++
 lib/arm/psci.c     | 37 ++++++++++++++++++++++++++++++++++++-
 3 files changed, 45 insertions(+), 1 deletion(-)

diff --git a/arm/Makefile.arm64 b/arm/Makefile.arm64
index 42e18e77..6dff6cad 100644
--- a/arm/Makefile.arm64
+++ b/arm/Makefile.arm64
@@ -25,6 +25,10 @@ cflatobjs += lib/arm64/processor.o
 cflatobjs += lib/arm64/spinlock.o
 cflatobjs += lib/arm64/gic-v3-its.o lib/arm64/gic-v3-its-cmd.o
 
+ifeq ($(CONFIG_EFI),y)
+cflatobjs += lib/acpi.o
+endif
+
 OBJDIRS += lib/arm64
 
 # arm64 specific tests
diff --git a/lib/acpi.h b/lib/acpi.h
index b714677e..ef4a8e1d 100644
--- a/lib/acpi.h
+++ b/lib/acpi.h
@@ -129,6 +129,11 @@ struct acpi_table_fadt {
 	u64 hypervisor_id;	/* Hypervisor Vendor ID (ACPI 6.0) */
 };
 
+/* Masks for FADT ARM Boot Architecture Flags (arm_boot_flags) ACPI 5.1 */
+
+#define ACPI_FADT_PSCI_COMPLIANT    (1)	/* 00: [V5+] PSCI 0.2+ is implemented */
+#define ACPI_FADT_PSCI_USE_HVC      (1<<1)	/* 01: [V5+] HVC must be used instead of SMC as the PSCI conduit */
+
 struct acpi_table_facs_rev1 {
 	u32 signature;		/* ACPI Signature */
 	u32 length;		/* Length of structure, in bytes */
diff --git a/lib/arm/psci.c b/lib/arm/psci.c
index 9c031a12..bddb0787 100644
--- a/lib/arm/psci.c
+++ b/lib/arm/psci.c
@@ -56,7 +56,7 @@ void psci_system_off(void)
 	printf("CPU%d unable to do system off (error = %d)\n", smp_processor_id(), err);
 }
 
-void psci_set_conduit(void)
+static void psci_set_conduit_fdt(void)
 {
 	const void *fdt = dt_fdt();
 	const struct fdt_property *method;
@@ -75,3 +75,38 @@ void psci_set_conduit(void)
 	else
 		assert_msg(false, "Unknown PSCI conduit: %s", method->data);
 }
+
+#ifdef CONFIG_EFI
+
+#include <acpi.h>
+
+static void psci_set_conduit_acpi(void)
+{
+	struct acpi_table_fadt *fadt = find_acpi_table_addr(FACP_SIGNATURE);
+
+	assert_msg(fadt, "Unable to find ACPI FADT");
+	assert_msg(fadt->arm_boot_flags & ACPI_FADT_PSCI_COMPLIANT,
+		   "PSCI is not supported in this platform");
+
+	if (fadt->arm_boot_flags & ACPI_FADT_PSCI_USE_HVC)
+		psci_invoke = psci_invoke_hvc;
+	else
+		psci_invoke = psci_invoke_smc;
+}
+
+#else
+
+static void psci_set_conduit_acpi(void)
+{
+	assert_msg(false, "ACPI not available");
+}
+
+#endif
+
+void psci_set_conduit(void)
+{
+	if (dt_available())
+		psci_set_conduit_fdt();
+	else
+		psci_set_conduit_acpi();
+}
-- 
2.25.1


  parent reply	other threads:[~2023-04-28 12:05 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 12:03 [kvm-unit-tests PATCH v5 00/29] EFI and ACPI support for arm64 Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 01/29] lib: Move acpi header and implementation to lib Nikos Nikoleris
2023-05-01 12:41   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 02/29] x86: Move x86_64-specific EFI CFLAGS to x86_64 Makefile Nikos Nikoleris
2023-05-01 12:41   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 03/29] lib: Apply Lindent to acpi.{c,h} Nikos Nikoleris
2023-05-01 12:44   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 04/29] lib: Fix style for acpi.{c,h} Nikos Nikoleris
2023-05-01 12:50   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 05/29] lib/acpi: Convert table names to Linux style Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 06/29] x86: Avoid references to fields of ACPI tables Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 07/29] lib/acpi: Ensure all struct definition for ACPI tables are packed Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 08/29] lib/acpi: Add support for the XSDT table Nikos Nikoleris
2023-05-01 12:50   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 09/29] lib/acpi: Extend the definition of the FADT table Nikos Nikoleris
2023-05-01 12:51   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 10/29] devicetree: Check that fdt is not NULL in dt_available() Nikos Nikoleris
2023-04-28 12:03 ` Nikos Nikoleris [this message]
2023-05-01 12:54   ` [kvm-unit-tests PATCH v5 11/29] arm64: Add support for setting up the PSCI conduit through ACPI Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 12/29] arm64: Add support for discovering the UART " Nikos Nikoleris
2023-05-01 12:55   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 13/29] arm64: Add support for timer initialization " Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 14/29] arm64: Add support for cpu " Nikos Nikoleris
2023-05-01 12:56   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 15/29] arm64: Add support for gic " Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 16/29] lib/printf: Support for precision modifier in printf Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 17/29] lib/printf: Add support for printing wide strings Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 18/29] lib/efi: Add support for getting the cmdline Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 19/29] arm/arm64: Rename etext to _etext Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 20/29] lib: Avoid ms_abi for calls related to EFI on arm64 Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 21/29] arm64: Add a new type of memory type flag MR_F_RESERVED Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 22/29] arm64: Add a setup sequence for systems that boot through EFI Nikos Nikoleris
2023-05-01 12:59   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 23/29] arm64: Copy code from GNU-EFI Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 24/29] arm64: Change GNU-EFI imported code to use defined types Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 25/29] arm64: Use code from the gnu-efi when booting with EFI Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 26/29] lib: Avoid external dependency in libelf Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 27/29] arm64: Add support for efi in Makefile Nikos Nikoleris
2023-05-01 13:00   ` Shaoqin Huang
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 28/29] lib: arm: Print test exit status Nikos Nikoleris
2023-05-01 13:00   ` Shaoqin Huang
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 29/29] arm64: Add an efi/run script Nikos Nikoleris
2023-05-01 12:48   ` Shaoqin Huang
2023-04-29 16:18 ` [kvm-unit-tests PATCH v5 00/29] EFI and ACPI support for arm64 Andrew Jones
2023-04-29 16:21   ` Andrew Jones
2023-04-30  0:02     ` Nikos Nikoleris
2023-05-01 11:21       ` Andrew Jones
2023-05-01 22:27         ` Nikos Nikoleris
2023-05-02  7:32           ` Andrew Jones
2023-05-05 14:55             ` Nikos Nikoleris
2023-05-01 12:09 ` Shaoqin Huang
2023-05-03 21:18   ` Nikos Nikoleris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428120405.3770496-12-nikos.nikoleris@arm.com \
    --to=nikos.nikoleris@arm.com \
    --cc=alexandru.elisei@arm.com \
    --cc=andrew.jones@linux.dev \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=ricarkol@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox