Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Nikos Nikoleris <nikos.nikoleris@arm.com>
To: kvm@vger.kernel.org, kvmarm@lists.linux.dev, andrew.jones@linux.dev
Cc: pbonzini@redhat.com, alexandru.elisei@arm.com, ricarkol@google.com
Subject: [kvm-unit-tests PATCH v5 08/29] lib/acpi: Add support for the XSDT table
Date: Fri, 28 Apr 2023 13:03:44 +0100	[thread overview]
Message-ID: <20230428120405.3770496-9-nikos.nikoleris@arm.com> (raw)
In-Reply-To: <20230428120405.3770496-1-nikos.nikoleris@arm.com>

XSDT provides pointers to other ACPI tables much like RSDT. However,
contrary to RSDT that provides 32-bit addresses, XSDT provides 64-bit
pointers. ACPI requires that if XSDT is valid then it takes precedence
over RSDT.

Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
[ Alex E: Use flexible array member for XSDT struct ]
Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
---
 lib/acpi.h |  6 ++++++
 lib/acpi.c | 40 ++++++++++++++++++++++++++++++++--------
 2 files changed, 38 insertions(+), 8 deletions(-)

diff --git a/lib/acpi.h b/lib/acpi.h
index 53e41c4b..74ba00ac 100644
--- a/lib/acpi.h
+++ b/lib/acpi.h
@@ -14,6 +14,7 @@
 
 #define RSDP_SIGNATURE ACPI_SIGNATURE('R','S','D','P')
 #define RSDT_SIGNATURE ACPI_SIGNATURE('R','S','D','T')
+#define XSDT_SIGNATURE ACPI_SIGNATURE('X','S','D','T')
 #define FACP_SIGNATURE ACPI_SIGNATURE('F','A','C','P')
 #define FACS_SIGNATURE ACPI_SIGNATURE('F','A','C','S')
 
@@ -56,6 +57,11 @@ struct acpi_table_rsdt_rev1 {
 	u32 table_offset_entry[];
 };
 
+struct acpi_table_xsdt {
+	ACPI_TABLE_HEADER_DEF
+	u64 table_offset_entry[];
+};
+
 struct acpi_table_fadt_rev1 {
 	ACPI_TABLE_HEADER_DEF	/* ACPI common table header */
 	u32 firmware_ctrl;	/* Physical address of FACS */
diff --git a/lib/acpi.c b/lib/acpi.c
index 166ffd14..d35f09a6 100644
--- a/lib/acpi.c
+++ b/lib/acpi.c
@@ -37,7 +37,8 @@ static struct acpi_table_rsdp *get_rsdp(void)
 
 void *find_acpi_table_addr(u32 sig)
 {
-	struct acpi_table_rsdt_rev1 *rsdt;
+	struct acpi_table_rsdt_rev1 *rsdt = NULL;
+	struct acpi_table_xsdt *xsdt = NULL;
 	struct acpi_table_rsdp *rsdp;
 	void *end;
 	int i;
@@ -62,18 +63,41 @@ void *find_acpi_table_addr(u32 sig)
 		return rsdp;
 
 	rsdt = (void *)(ulong) rsdp->rsdt_physical_address;
-	if (!rsdt || rsdt->signature != RSDT_SIGNATURE)
-		return NULL;
+	if (rsdt && rsdt->signature != RSDT_SIGNATURE)
+		rsdt = NULL;
 
 	if (sig == RSDT_SIGNATURE)
 		return rsdt;
 
-	end = (void *)rsdt + rsdt->length;
-	for (i = 0; (void *)&rsdt->table_offset_entry[i] < end; i++) {
-		struct acpi_table *t = (void *)(ulong) rsdt->table_offset_entry[i];
+	if (rsdp->revision >= 2) {
+		xsdt = (void *)rsdp->xsdt_physical_address;
+		if (xsdt && xsdt->signature != XSDT_SIGNATURE)
+			xsdt = NULL;
+	}
 
-		if (t && t->signature == sig)
-			return t;
+	if (sig == XSDT_SIGNATURE)
+		return xsdt;
+
+	/*
+	 * When the system implements APCI 2.0 and above and XSDT is valid we
+	 * have use XSDT to find other ACPI tables, otherwise, we use RSDT.
+	 */
+	if (xsdt) {
+		end = (void *)xsdt + xsdt->length;
+		for (i = 0; (void *)&xsdt->table_offset_entry[i] < end; i++) {
+			struct acpi_table *t = (void *)(ulong) xsdt->table_offset_entry[i];
+
+			if (t && t->signature == sig)
+				return t;
+		}
+	} else if (rsdt) {
+		end = (void *)rsdt + rsdt->length;
+		for (i = 0; (void *)&rsdt->table_offset_entry[i] < end; i++) {
+			struct acpi_table *t = (void *)(ulong) rsdt->table_offset_entry[i];
+
+			if (t && t->signature == sig)
+				return t;
+		}
 	}
 
 	return NULL;
-- 
2.25.1


  parent reply	other threads:[~2023-04-28 12:05 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 12:03 [kvm-unit-tests PATCH v5 00/29] EFI and ACPI support for arm64 Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 01/29] lib: Move acpi header and implementation to lib Nikos Nikoleris
2023-05-01 12:41   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 02/29] x86: Move x86_64-specific EFI CFLAGS to x86_64 Makefile Nikos Nikoleris
2023-05-01 12:41   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 03/29] lib: Apply Lindent to acpi.{c,h} Nikos Nikoleris
2023-05-01 12:44   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 04/29] lib: Fix style for acpi.{c,h} Nikos Nikoleris
2023-05-01 12:50   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 05/29] lib/acpi: Convert table names to Linux style Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 06/29] x86: Avoid references to fields of ACPI tables Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 07/29] lib/acpi: Ensure all struct definition for ACPI tables are packed Nikos Nikoleris
2023-04-28 12:03 ` Nikos Nikoleris [this message]
2023-05-01 12:50   ` [kvm-unit-tests PATCH v5 08/29] lib/acpi: Add support for the XSDT table Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 09/29] lib/acpi: Extend the definition of the FADT table Nikos Nikoleris
2023-05-01 12:51   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 10/29] devicetree: Check that fdt is not NULL in dt_available() Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 11/29] arm64: Add support for setting up the PSCI conduit through ACPI Nikos Nikoleris
2023-05-01 12:54   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 12/29] arm64: Add support for discovering the UART " Nikos Nikoleris
2023-05-01 12:55   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 13/29] arm64: Add support for timer initialization " Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 14/29] arm64: Add support for cpu " Nikos Nikoleris
2023-05-01 12:56   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 15/29] arm64: Add support for gic " Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 16/29] lib/printf: Support for precision modifier in printf Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 17/29] lib/printf: Add support for printing wide strings Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 18/29] lib/efi: Add support for getting the cmdline Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 19/29] arm/arm64: Rename etext to _etext Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 20/29] lib: Avoid ms_abi for calls related to EFI on arm64 Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 21/29] arm64: Add a new type of memory type flag MR_F_RESERVED Nikos Nikoleris
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 22/29] arm64: Add a setup sequence for systems that boot through EFI Nikos Nikoleris
2023-05-01 12:59   ` Shaoqin Huang
2023-04-28 12:03 ` [kvm-unit-tests PATCH v5 23/29] arm64: Copy code from GNU-EFI Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 24/29] arm64: Change GNU-EFI imported code to use defined types Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 25/29] arm64: Use code from the gnu-efi when booting with EFI Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 26/29] lib: Avoid external dependency in libelf Nikos Nikoleris
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 27/29] arm64: Add support for efi in Makefile Nikos Nikoleris
2023-05-01 13:00   ` Shaoqin Huang
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 28/29] lib: arm: Print test exit status Nikos Nikoleris
2023-05-01 13:00   ` Shaoqin Huang
2023-04-28 12:04 ` [kvm-unit-tests PATCH v5 29/29] arm64: Add an efi/run script Nikos Nikoleris
2023-05-01 12:48   ` Shaoqin Huang
2023-04-29 16:18 ` [kvm-unit-tests PATCH v5 00/29] EFI and ACPI support for arm64 Andrew Jones
2023-04-29 16:21   ` Andrew Jones
2023-04-30  0:02     ` Nikos Nikoleris
2023-05-01 11:21       ` Andrew Jones
2023-05-01 22:27         ` Nikos Nikoleris
2023-05-02  7:32           ` Andrew Jones
2023-05-05 14:55             ` Nikos Nikoleris
2023-05-01 12:09 ` Shaoqin Huang
2023-05-03 21:18   ` Nikos Nikoleris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428120405.3770496-9-nikos.nikoleris@arm.com \
    --to=nikos.nikoleris@arm.com \
    --cc=alexandru.elisei@arm.com \
    --cc=andrew.jones@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=ricarkol@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox