Re: [PATCH v6 2/7] KVM: x86: Move PML page to common vcpu arch structure

["Nikunj A. Dadhania" <nikunj@amd.com>]

On 5/9/2026 4:27 AM, Sean Christopherson wrote:
> On Tue, Apr 07, 2026, Nikunj A Dadhania wrote:
>> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>> index b77750a2efc2..909085a5dfb3 100644
>> --- a/arch/x86/kvm/vmx/vmx.c
>> +++ b/arch/x86/kvm/vmx/vmx.c
>> @@ -4934,7 +4934,8 @@ int vmx_vcpu_precreate(struct kvm *kvm)
>>  
>>  static void init_vmcs(struct vcpu_vmx *vmx)
>>  {
>> -	struct kvm *kvm = vmx->vcpu.kvm;
>> +	struct kvm_vcpu *vcpu = &vmx->vcpu;
>> +	struct kvm *kvm = vcpu->kvm;
> 
> There are 9+ existing uses of "vmx->vcpu" in init_vmcs().  I'd rather insert a
> prep patch to pass @vcpu instead of @vmx, do to_vmx() at the top, and switch all
> existing vmx->vcpu usage.
> 
> From: Sean Christopherson <seanjc@google.com>
> Date: Fri, 8 May 2026 15:55:55 -0700
> Subject: [PATCH] KVM: VMX: Pass @vcpu, not @vmx to init_vmcs()
> 
> Pass @vcpu instead of @vmx to init_vmcs(), and switch all of the vmx->vcpu
> usage to a simple vcpu.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Ack. I’ll include this as a preparatory patch in my series unless it
lands in your tree before I post.

Regards,
Nikunj