From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Sean Christopherson <seanjc@google.com>
Cc: <kvm@vger.kernel.org>, <pbonzini@redhat.com>,
<thomas.lendacky@amd.com>, <bp@alien8.de>,
<joao.m.martins@oracle.com>, <kai.huang@intel.com>
Subject: Re: [PATCH v6 1/7] KVM: x86: Carve out PML flush routine
Date: Tue, 12 May 2026 11:06:14 +0530 [thread overview]
Message-ID: <5e3c6707-ec77-4ff3-825c-6b15e89582c0@amd.com> (raw)
In-Reply-To: <af5pLI6MylNvpZVy@google.com>
On 5/9/2026 4:22 AM, Sean Christopherson wrote:
> On Tue, Apr 07, 2026, Nikunj A Dadhania wrote:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index fd1c4a36b593..628b6f51d2be 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -6720,6 +6720,37 @@ void kvm_arch_sync_dirty_log(struct kvm *kvm, struct kvm_memory_slot *memslot)
>> kvm_vcpu_kick(vcpu);
>> }
>>
>> +void kvm_flush_pml_buffer(struct kvm_vcpu *vcpu, struct page *pml_page, u16 pml_idx)
>
> Swap the order of patches 1 and 2, then you don't need to add @pml_page, only to
> remove it one patch later.
That makes sense—I'll swap the order of patches 1 and 2 and address this in my next revision.
Regards,
Nikunj
next prev parent reply other threads:[~2026-05-12 5:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 6:32 [PATCH v6 0/7] KVM: SVM: Add Page Modification Logging (PML) support Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 1/7] KVM: x86: Carve out PML flush routine Nikunj A Dadhania
2026-05-08 22:52 ` Sean Christopherson
2026-05-12 5:36 ` Nikunj A. Dadhania [this message]
2026-04-07 6:32 ` [PATCH v6 2/7] KVM: x86: Move PML page to common vcpu arch structure Nikunj A Dadhania
2026-05-08 22:57 ` Sean Christopherson
2026-05-12 5:45 ` Nikunj A. Dadhania
2026-04-07 6:32 ` [PATCH v6 3/7] KVM: VMX: Use cpu_dirty_log_size instead of enable_pml for PML checks Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 4/7] x86/cpufeatures: Add Page modification logging Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 5/7] KVM: SVM: Use BIT_ULL for 64-bit nested_ctl bit definitions Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 6/7] KVM: nSVM: Add helpers to temporarily switch to vmcb01 Nikunj A Dadhania
2026-04-07 6:32 ` [PATCH v6 7/7] KVM: SVM: Add Page modification logging support Nikunj A Dadhania
2026-04-20 6:38 ` Nikunj A. Dadhania
2026-04-21 15:08 ` Sean Christopherson
2026-04-21 23:50 ` Huang, Kai
2026-04-22 0:30 ` Sean Christopherson
2026-04-22 1:42 ` Huang, Kai
2026-04-22 5:59 ` Nikunj A. Dadhania
2026-04-22 8:14 ` Huang, Kai
2026-04-22 13:20 ` Sean Christopherson
2026-04-22 22:14 ` Huang, Kai
2026-04-24 16:25 ` Tom Lendacky
2026-04-25 14:45 ` Tom Lendacky
2026-04-27 20:16 ` Sean Christopherson
2026-04-21 23:04 ` Yosry Ahmed
2026-04-21 23:15 ` Sean Christopherson
2026-04-22 6:26 ` Nikunj A. Dadhania
2026-04-22 19:48 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3c6707-ec77-4ff3-825c-6b15e89582c0@amd.com \
--to=nikunj@amd.com \
--cc=bp@alien8.de \
--cc=joao.m.martins@oracle.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox