public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>,
	Pierre Morel <pmorel@linux.ibm.com>,
	linux-s390@vger.kernel.org
Cc: thuth@redhat.com, kvm@vger.kernel.org, cohuck@redhat.com,
	imbrenda@linux.ibm.com, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v4 2/4] s390x: stsi: Define vm_is_kvm to be used in different tests
Date: Tue, 08 Feb 2022 16:43:16 +0100	[thread overview]
Message-ID: <be515acc30a69e5cbf2f01828685844b7beb0856.camel@linux.ibm.com> (raw)
In-Reply-To: <62c23e3a-8cc9-2072-6022-cb23dfa08ce7@linux.ibm.com>

On Tue, 2022-02-08 at 16:31 +0100, Janosch Frank wrote:
> > diff --git a/lib/s390x/stsi.h b/lib/s390x/stsi.h
> > new file mode 100644
> > index 00000000..9b40664f
> > --- /dev/null
> > +++ b/lib/s390x/stsi.h
> > @@ -0,0 +1,32 @@
> > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > +/*
> > + * Structures used to Store System Information
> > + *
> > + * Copyright IBM Corp. 2022
> > + */
> > +
> > +#ifndef _S390X_STSI_H_
> > +#define _S390X_STSI_H_
> > +
> > +struct sysinfo_3_2_2 {
> 
> Any particular reason why you renamed this?

Stumbled across this as well. I think this makes it consistent with
Linux' arch/s390/include/asm/sysinfo.h.

The PoP, on the other hand, calls it SYSIB, so this at least resolves
the inconsistency between kvm-unit-tests and Linux.

  reply	other threads:[~2022-02-08 15:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 13:27 [kvm-unit-tests PATCH v4 0/4] S390x: CPU Topology Information Pierre Morel
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 1/4] s390x: lib: Add SCLP toplogy nested level Pierre Morel
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 2/4] s390x: stsi: Define vm_is_kvm to be used in different tests Pierre Morel
2022-02-08 15:31   ` Janosch Frank
2022-02-08 15:43     ` Nico Boehr [this message]
2022-02-14  8:01       ` Pierre Morel
2022-02-14  9:18     ` Pierre Morel
2022-02-08 15:35   ` Nico Boehr
2022-02-14  7:55     ` Pierre Morel
2022-02-15 11:18   ` Claudio Imbrenda
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 3/4] s390x: topology: Check the Perform Topology Function Pierre Morel
2022-02-09 11:37   ` Nico Boehr
2022-02-14  9:21     ` Pierre Morel
2022-02-15  8:29     ` Pierre Morel
2022-02-15  8:50     ` Pierre Morel
2022-02-15  9:21       ` Pierre Morel
2022-02-15  9:44         ` Pierre Morel
2022-02-15 10:28           ` Nico Boehr
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 4/4] s390x: topology: Checking Configuration Topology Information Pierre Morel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be515acc30a69e5cbf2f01828685844b7beb0856.camel@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pmorel@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox