From: Nico Boehr <nrb@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, thuth@redhat.com, kvm@vger.kernel.org,
cohuck@redhat.com, imbrenda@linux.ibm.com, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v4 3/4] s390x: topology: Check the Perform Topology Function
Date: Tue, 15 Feb 2022 11:28:43 +0100 [thread overview]
Message-ID: <cc1d20c1b53631271e51ed85e892fc6a9eee71d0.camel@linux.ibm.com> (raw)
In-Reply-To: <1e9cfea2-c48c-fe2d-3e26-52ff0db1225b@linux.ibm.com>
On Tue, 2022-02-15 at 10:44 +0100, Pierre Morel wrote:
> > > > - second operand is ignored.
> > >
> > > Which second operand?
> >
> > Sorry got it
>
> I was a little fast in my answer, twice.
> If the second operand is ignored, how would you like to check
> something
> like that?
> We can check that the result of the instruction is identical for the
> known effects the user can check what ever we put in there but how
> can
> we know if it is really ignored?
Yes, there is no 100% guarantee. If you think there is no value or it's
too difficult to test for the value it adds, it is fine for me if you
leave it out.
Your suggestion sounds fine, though.
next prev parent reply other threads:[~2022-02-15 10:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 13:27 [kvm-unit-tests PATCH v4 0/4] S390x: CPU Topology Information Pierre Morel
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 1/4] s390x: lib: Add SCLP toplogy nested level Pierre Morel
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 2/4] s390x: stsi: Define vm_is_kvm to be used in different tests Pierre Morel
2022-02-08 15:31 ` Janosch Frank
2022-02-08 15:43 ` Nico Boehr
2022-02-14 8:01 ` Pierre Morel
2022-02-14 9:18 ` Pierre Morel
2022-02-08 15:35 ` Nico Boehr
2022-02-14 7:55 ` Pierre Morel
2022-02-15 11:18 ` Claudio Imbrenda
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 3/4] s390x: topology: Check the Perform Topology Function Pierre Morel
2022-02-09 11:37 ` Nico Boehr
2022-02-14 9:21 ` Pierre Morel
2022-02-15 8:29 ` Pierre Morel
2022-02-15 8:50 ` Pierre Morel
2022-02-15 9:21 ` Pierre Morel
2022-02-15 9:44 ` Pierre Morel
2022-02-15 10:28 ` Nico Boehr [this message]
2022-02-08 13:27 ` [kvm-unit-tests PATCH v4 4/4] s390x: topology: Checking Configuration Topology Information Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc1d20c1b53631271e51ed85e892fc6a9eee71d0.camel@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox