SPLINT: sys_open missing a parameter in init/main.c

SPLINT: sys_open missing a parameter in init/main.c

[Riley Williams]

Hi Harry.

The funtion sys_open is defined with three parameters...

	int sys_open(char *filename, int flags, int mode);

...but in init/main.c it is called with only two parameters...

	#ifdef CONFIG_CONSOLE_SERIAL
		num = sys_open("/dev/ttyS0", 2);
	#else
		num = sys_open("/dev/tty1", 2);
	#endif

...and I haven't the foggiest how to correct this. Can somebody rather
more knowledgable than I am advise regarding this please?

Best wishes from Riley.

Re: SPLINT: sys_open missing a parameter in init/main.c

[Christoph Plattner]

In the standard the "mode" argument is optional. It is only used
together 
with O_CREAT as flag to define the file mode (see UNIX command chmod,
etc).

It is not a "beautiful" way, but this usage works. The third parameter
is not defined at call, and if O_CREAT is not used, this argument with
the not define value is not read.

A correct implementation is done by using the va_args ! A C-method to
pass variable amount of arguments. See for example printf(), how it is
implemented !

With friendly regards
Christoph P.


Riley Williams wrote:
> 
> Hi Harry.
> 
> The funtion sys_open is defined with three parameters...
> 
>         int sys_open(char *filename, int flags, int mode);
> 
> ...but in init/main.c it is called with only two parameters...
> 
>         #ifdef CONFIG_CONSOLE_SERIAL
>                 num = sys_open("/dev/ttyS0", 2);
>         #else
>                 num = sys_open("/dev/tty1", 2);
>         #endif
> 
> ...and I haven't the foggiest how to correct this. Can somebody rather
> more knowledgable than I am advise regarding this please?
> 
> Best wishes from Riley.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-8086" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
-------------------------------------------------------
private:	christoph.plattner@gmx.at
company:	christoph.plattner@alcatel.at

Re: SPLINT: sys_open missing a parameter in init/main.c

[Alan Cox]

> The funtion sys_open is defined with three parameters...
> 	int sys_open(char *filename, int flags, int mode);
> 
> ...but in init/main.c it is called with only two parameters...

Thats sort of fine. The third parameter is optional in open() syscalls and
is the mode for creation. Historically ancient unix had creat() and no
3 argument open.

> ...and I haven't the foggiest how to correct this. Can somebody rather
> more knowledgable than I am advise regarding this please?

Stuff a ",0" on the end - its not needed but its good for correctness and
portability

Re: SPLINT: sys_open missing a parameter in init/main.c

[Riley Williams]

Hi Alan.

>> The funtion sys_open is defined with three parameters...
>>
>>	int sys_open(char *filename, int flags, int mode);
>>
>> ...but in init/main.c it is called with only two parameters...

> Thats sort of fine. The third parameter is optional in open()
> syscalls and is the mode for creation. Historically ancient unix
> had creat() and no 3 argument open.

Ah...

>> ...and I haven't the foggiest how to correct this. Can somebody
>> rather more knowledgable than I am advise regarding this please?

> Stuff a ",0" on the end - its not needed but its good for
> correctness and portability

Many thanks. I've now done that in init/main.c and committed the
result, so that file (and, therefore, that directory) is now clean
as far as `splint -weak` is concerned.

Best wishes from Riley.