[PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[Sérgio Monteiro Basto]

[-- Attachment #1: Type: text/plain, Size: 100 bytes --]


bus.c:1887: warning: implicit declaration of function
`mp_config_ioapic_for_sci'

A trivial patch


[-- Attachment #2: acpi_explicit.diff --]
[-- Type: text/plain, Size: 628 bytes --]

--- linux-2.4.19acpi/include/asm-i386/mpspec.h.orig	Sun Oct  6 21:27:06 2002
+++ linux-2.4.19acpi/include/asm-i386/mpspec.h	Sun Oct  6 21:34:06 2002
@@ -228,9 +228,11 @@
 extern void mp_register_ioapic (u8 id, u32 address, u32 irq_base);
 extern void mp_override_legacy_irq (u8 bus_irq, u8 polarity, u8 trigger, u32 global_irq);
 extern void mp_config_acpi_legacy_irqs (void);
-extern void mp_config_ioapic_for_sci(int irq);
 extern void mp_parse_prt (void);
 #endif /*CONFIG_X86_IO_APIC*/
+#ifdef CONFIG_X86
+extern void mp_config_ioapic_for_sci(int irq);
+#endif /*CONFIG_X86*/
 
 #endif /*CONFIG_ACPI_BOOT*/
 

Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[Matthew Wilcox]

On Tue, Oct 08, 2002 at 02:55:57AM -0400, Sérgio Monteiro Basto wrote:
> +++ linux-2.4.19acpi/include/asm-i386/mpspec.h	Sun Oct  6 21:34:06 2002
                               ^^^^^^^^
> +#ifdef CONFIG_X86
> +extern void mp_config_ioapic_for_sci(int irq);
> +#endif /*CONFIG_X86*/

you really don't need to encase this in CONFIG_X86.  if it's in asm-i386
and some other cpu type is including this file, things are already
hideously wrong.

-- 
Revolutions do not require corporate support.


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[Sérgio Monteiro Basto]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

First of all thanks for replying to this email and for the information.

so I remade the patch, and (I think) now is a good patch, because is not
need declared the mp_config_ioapic_for_sci function.


On Tue, 2002-10-08 at 07:59, Matthew Wilcox wrote: 
> On Tue, Oct 08, 2002 at 02:55:57AM -0400, Sérgio Monteiro Basto wrote:
> > +++ linux-2.4.19acpi/include/asm-i386/mpspec.h	Sun Oct  6 21:34:06 2002
>                                ^^^^^^^^
> > +#ifdef CONFIG_X86
> > +extern void mp_config_ioapic_for_sci(int irq);
> > +#endif /*CONFIG_X86*/
> 
> you really don't need to encase this in CONFIG_X86.  if it's in asm-i386
> and some other cpu type is including this file, things are already
> hideously wrong.
> 
> -- 
> Revolutions do not require corporate support.
> 

[-- Attachment #2: acpi_explicit2.diff --]
[-- Type: text/plain, Size: 558 bytes --]

--- linux-2.4.19orig/drivers/acpi/bus.c	Sun Oct  6 21:39:56 2002
+++ linux-2.4.19acpi/drivers/acpi/bus.c	Wed Oct  9 01:00:12 2002
@@ -1883,10 +1883,14 @@
 
 #ifdef CONFIG_X86
         /* Ensure the SCI is set to level-triggered, active-low */
+#ifdef CONFIG_X86_IO_APIC
         if (acpi_ioapic)
          	mp_config_ioapic_for_sci(acpi_fadt.sci_int);
 	else
                 eisa_set_level_irq(acpi_fadt.sci_int);
+#else
+	eisa_set_level_irq(acpi_fadt.sci_int);
+#endif
 #endif
 
 	status = acpi_enable_subsystem(ACPI_FULL_INITIALIZATION);

Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[Matthew Wilcox]

On Wed, Oct 09, 2002 at 01:14:13AM -0400, Sérgio Monteiro Basto wrote:
> First of all thanks for replying to this email and for the information.
> 
> so I remade the patch, and (I think) now is a good patch, because is not
> need declared the mp_config_ioapic_for_sci function.

> --- linux-2.4.19orig/drivers/acpi/bus.c	Sun Oct  6 21:39:56 2002
> +++ linux-2.4.19acpi/drivers/acpi/bus.c	Wed Oct  9 01:00:12 2002
> @@ -1883,10 +1883,14 @@
>  
>  #ifdef CONFIG_X86
>          /* Ensure the SCI is set to level-triggered, active-low */
> +#ifdef CONFIG_X86_IO_APIC
>          if (acpi_ioapic)
>           	mp_config_ioapic_for_sci(acpi_fadt.sci_int);
>  	else
>                  eisa_set_level_irq(acpi_fadt.sci_int);
> +#else
> +	eisa_set_level_irq(acpi_fadt.sci_int);
> +#endif
>  #endif
>  
>  	status = acpi_enable_subsystem(ACPI_FULL_INITIALIZATION);

the normal way to do this kind of this is:

>  #ifdef CONFIG_X86
>          /* Ensure the SCI is set to level-triggered, active-low */
> +#ifdef CONFIG_X86_IO_APIC
>          if (acpi_ioapic)
>           	mp_config_ioapic_for_sci(acpi_fadt.sci_int);
>  	else
> +#endif
>                  eisa_set_level_irq(acpi_fadt.sci_int);
>  #endif

(could someone fix the indenting here?  it's a mess!)

-- 
Revolutions do not require corporate support.


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[Sérgio Monteiro Basto]

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

On Wed, 2002-10-09 at 09:42, Matthew Wilcox wrote:
> (could someone fix the indenting here?  it's a mess!)


[-- Attachment #2: acpi_explicit3.diff --]
[-- Type: text/plain, Size: 710 bytes --]

--- linux-2.4.19orig/drivers/acpi/bus.c	Sun Oct  6 21:39:56 2002
+++ linux-2.4.19acpi/drivers/acpi/bus.c	Thu Oct 10 00:08:02 2002
@@ -1883,11 +1883,14 @@
 
 #ifdef CONFIG_X86
         /* Ensure the SCI is set to level-triggered, active-low */
-        if (acpi_ioapic)
-         	mp_config_ioapic_for_sci(acpi_fadt.sci_int);
+#ifdef CONFIG_X86_IO_APIC
+	if (acpi_ioapic)
+		mp_config_ioapic_for_sci(acpi_fadt.sci_int);
 	else
-                eisa_set_level_irq(acpi_fadt.sci_int);
-#endif
+#else
+		eisa_set_level_irq(acpi_fadt.sci_int);
+#endif /* CONFIG_X86_IO_APIC */
+#endif /* CONFIG_X86 */
 
 	status = acpi_enable_subsystem(ACPI_FULL_INITIALIZATION);
 	if (ACPI_FAILURE(status)) {

Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[Sérgio Monteiro Basto]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

On Wed, 2002-10-09 at 09:42, Matthew Wilcox wrote:
> (could someone fix the indenting here?  it's a mess!)
sorry 2nd time ..., please ignore my last message.

[-- Attachment #2: acpi_explicit3.diff --]
[-- Type: text/plain, Size: 710 bytes --]

--- linux-2.4.19orig/drivers/acpi/bus.c	Sun Oct  6 21:39:56 2002
+++ linux-2.4.19acpi/drivers/acpi/bus.c	Thu Oct 10 00:08:02 2002
@@ -1883,11 +1883,14 @@
 
 #ifdef CONFIG_X86
         /* Ensure the SCI is set to level-triggered, active-low */
-        if (acpi_ioapic)
-         	mp_config_ioapic_for_sci(acpi_fadt.sci_int);
+#ifdef CONFIG_X86_IO_APIC
+	if (acpi_ioapic)
+		mp_config_ioapic_for_sci(acpi_fadt.sci_int);
 	else
-                eisa_set_level_irq(acpi_fadt.sci_int);
-#endif
+#else
+		eisa_set_level_irq(acpi_fadt.sci_int);
+#endif /* CONFIG_X86_IO_APIC */
+#endif /* CONFIG_X86 */
 
 	status = acpi_enable_subsystem(ACPI_FULL_INITIALIZATION);
 	if (ACPI_FAILURE(status)) {

Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci

[Sérgio Monteiro Basto]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

On Wed, 2002-10-09 at 09:42, Matthew Wilcox wrote:
> (could someone fix the indenting here?  it's a mess!)
sorry 3rd time ..., please ignore and delete, my last message again.
thanks
Sérgio Basto

[-- Attachment #2: acpi_explicit4.diff --]
[-- Type: text/plain, Size: 777 bytes --]

--- linux-2.4.19orig/drivers/acpi/bus.c	Sun Oct  6 21:39:56 2002
+++ linux-2.4.19acpi/drivers/acpi/bus.c	Thu Oct 10 00:32:24 2002
@@ -1882,12 +1882,15 @@
 	}
 
 #ifdef CONFIG_X86
-        /* Ensure the SCI is set to level-triggered, active-low */
-        if (acpi_ioapic)
-         	mp_config_ioapic_for_sci(acpi_fadt.sci_int);
+	/* Ensure the SCI is set to level-triggered, active-low */
+#ifdef CONFIG_X86_IO_APIC
+	if (acpi_ioapic)
+		mp_config_ioapic_for_sci(acpi_fadt.sci_int);
 	else
-                eisa_set_level_irq(acpi_fadt.sci_int);
-#endif
+#else
+		eisa_set_level_irq(acpi_fadt.sci_int);
+#endif /* CONFIG_X86_IO_APIC */
+#endif /* CONFIG_X86 */
 
 	status = acpi_enable_subsystem(ACPI_FULL_INITIALIZATION);
 	if (ACPI_FAILURE(status)) {