* [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro @ 2024-06-23 4:34 Jeff Johnson 2024-07-09 19:53 ` Jeff Johnson 0 siblings, 1 reply; 6+ messages in thread From: Jeff Johnson @ 2024-06-23 4:34 UTC (permalink / raw) To: Russell King Cc: linux-arm-kernel, linux-kernel, kernel-janitors, Jeff Johnson With ARCH=arm, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- arch/arm/probes/kprobes/test-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c index 171c7076b89f..6e9041a76b8b 100644 --- a/arch/arm/probes/kprobes/test-core.c +++ b/arch/arm/probes/kprobes/test-core.c @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void) module_init(run_all_tests) module_exit(kprobe_test_exit) +MODULE_DESCRIPTION("ARM kprobes test module"); MODULE_LICENSE("GPL"); #else /* !MODULE */ --- base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro 2024-06-23 4:34 [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro Jeff Johnson @ 2024-07-09 19:53 ` Jeff Johnson 2024-07-19 11:28 ` Arnd Bergmann 0 siblings, 1 reply; 6+ messages in thread From: Jeff Johnson @ 2024-07-09 19:53 UTC (permalink / raw) To: Russell King; +Cc: linux-arm-kernel, linux-kernel, kernel-janitors On 6/22/2024 9:34 PM, Jeff Johnson wrote: > With ARCH=arm, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > arch/arm/probes/kprobes/test-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c > index 171c7076b89f..6e9041a76b8b 100644 > --- a/arch/arm/probes/kprobes/test-core.c > +++ b/arch/arm/probes/kprobes/test-core.c > @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void) > > module_init(run_all_tests) > module_exit(kprobe_test_exit) > +MODULE_DESCRIPTION("ARM kprobes test module"); > MODULE_LICENSE("GPL"); > > #else /* !MODULE */ > > --- > base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b > change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3 I don't see this in linux-next yet so following up to see if anything else is needed to get this merged. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro 2024-07-09 19:53 ` Jeff Johnson @ 2024-07-19 11:28 ` Arnd Bergmann 2024-07-19 14:03 ` Jeff Johnson 2026-05-03 21:12 ` Randy Dunlap 0 siblings, 2 replies; 6+ messages in thread From: Arnd Bergmann @ 2024-07-19 11:28 UTC (permalink / raw) To: Jeff Johnson, Russell King Cc: linux-arm-kernel, linux-kernel, kernel-janitors On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote: > On 6/22/2024 9:34 PM, Jeff Johnson wrote: >> With ARCH=arm, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o >> >> Add the missing invocation of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >> --- >> arch/arm/probes/kprobes/test-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c >> index 171c7076b89f..6e9041a76b8b 100644 >> --- a/arch/arm/probes/kprobes/test-core.c >> +++ b/arch/arm/probes/kprobes/test-core.c >> @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void) >> >> module_init(run_all_tests) >> module_exit(kprobe_test_exit) >> +MODULE_DESCRIPTION("ARM kprobes test module"); >> MODULE_LICENSE("GPL"); >> >> #else /* !MODULE */ >> >> --- >> base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b >> change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3 > > I don't see this in linux-next yet so following up to see if anything else is > needed to get this merged. Hi Jeff, The arm tree uses a separate submission system for reviewed patches to get into the tree, see https://www.arm.linux.org.uk/developer/patches/info.php https://www.arm.linux.org.uk/developer/patches/section.php?section=0 I looked at this file as well during build testing and ended up combining the change with a cleanup, If you like, I can send my version instead, see below. Arnd diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c index 171c7076b89f..0c6639509eff 100644 --- a/arch/arm/probes/kprobes/test-core.c +++ b/arch/arm/probes/kprobes/test-core.c @@ -1650,24 +1650,16 @@ static int __init run_all_tests(void) return ret; } - +late_initcall(run_all_tests); /* * Module setup */ -#ifdef MODULE - static void __exit kprobe_test_exit(void) { } - -module_init(run_all_tests) module_exit(kprobe_test_exit) -MODULE_LICENSE("GPL"); -#else /* !MODULE */ - -late_initcall(run_all_tests); - -#endif +MODULE_DESCRIPTION("Test code for ARM kprobes"); +MODULE_LICENSE("GPL"); ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro 2024-07-19 11:28 ` Arnd Bergmann @ 2024-07-19 14:03 ` Jeff Johnson 2026-05-03 21:12 ` Randy Dunlap 1 sibling, 0 replies; 6+ messages in thread From: Jeff Johnson @ 2024-07-19 14:03 UTC (permalink / raw) To: Arnd Bergmann, Russell King Cc: linux-arm-kernel, linux-kernel, kernel-janitors On 7/19/2024 4:28 AM, Arnd Bergmann wrote: > On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote: >> On 6/22/2024 9:34 PM, Jeff Johnson wrote: >>> With ARCH=arm, make allmodconfig && make W=1 C=1 reports: >>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o >>> >>> Add the missing invocation of the MODULE_DESCRIPTION() macro. >>> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >>> --- >>> arch/arm/probes/kprobes/test-core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c >>> index 171c7076b89f..6e9041a76b8b 100644 >>> --- a/arch/arm/probes/kprobes/test-core.c >>> +++ b/arch/arm/probes/kprobes/test-core.c >>> @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void) >>> >>> module_init(run_all_tests) >>> module_exit(kprobe_test_exit) >>> +MODULE_DESCRIPTION("ARM kprobes test module"); >>> MODULE_LICENSE("GPL"); >>> >>> #else /* !MODULE */ >>> >>> --- >>> base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b >>> change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3 >> >> I don't see this in linux-next yet so following up to see if anything else is >> needed to get this merged. > > Hi Jeff, > > The arm tree uses a separate submission system for reviewed > patches to get into the tree, see > > https://www.arm.linux.org.uk/developer/patches/info.php > https://www.arm.linux.org.uk/developer/patches/section.php?section=0 Thanks for the pointer. Hard to keep track of these when submitting tree-wide! > I looked at this file as well during build testing > and ended up combining the change with a cleanup, > If you like, I can send my version instead, see below. Please send your version since it has additional cleanup. /jeff ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro 2024-07-19 11:28 ` Arnd Bergmann 2024-07-19 14:03 ` Jeff Johnson @ 2026-05-03 21:12 ` Randy Dunlap 2026-05-04 7:01 ` Arnd Bergmann 1 sibling, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2026-05-03 21:12 UTC (permalink / raw) To: Arnd Bergmann, Jeff Johnson, Russell King Cc: linux-arm-kernel, linux-kernel, kernel-janitors Hi Arnd, On 7/19/24 4:28 AM, Arnd Bergmann wrote: > On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote: >> On 6/22/2024 9:34 PM, Jeff Johnson wrote: >>> With ARCH=arm, make allmodconfig && make W=1 C=1 reports: >>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o >>> >>> Add the missing invocation of the MODULE_DESCRIPTION() macro. >>> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >>> --- >>> arch/arm/probes/kprobes/test-core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c >>> index 171c7076b89f..6e9041a76b8b 100644 >>> --- a/arch/arm/probes/kprobes/test-core.c >>> +++ b/arch/arm/probes/kprobes/test-core.c >>> @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void) >>> >>> module_init(run_all_tests) >>> module_exit(kprobe_test_exit) >>> +MODULE_DESCRIPTION("ARM kprobes test module"); >>> MODULE_LICENSE("GPL"); >>> >>> #else /* !MODULE */ >>> >>> --- >>> base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b >>> change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3 >> >> I don't see this in linux-next yet so following up to see if anything else is >> needed to get this merged. > > Hi Jeff, > > The arm tree uses a separate submission system for reviewed > patches to get into the tree, see > > https://www.arm.linux.org.uk/developer/patches/info.php > https://www.arm.linux.org.uk/developer/patches/section.php?section=0 > > I looked at this file as well during build testing > and ended up combining the change with a cleanup, > If you like, I can send my version instead, see below. > > Arnd > > diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c > index 171c7076b89f..0c6639509eff 100644 > --- a/arch/arm/probes/kprobes/test-core.c > +++ b/arch/arm/probes/kprobes/test-core.c > @@ -1650,24 +1650,16 @@ static int __init run_all_tests(void) > > return ret; > } > - > +late_initcall(run_all_tests); > > /* > * Module setup > */ > > -#ifdef MODULE > - > static void __exit kprobe_test_exit(void) > { > } > - > -module_init(run_all_tests) > module_exit(kprobe_test_exit) > -MODULE_LICENSE("GPL"); > > -#else /* !MODULE */ > - > -late_initcall(run_all_tests); > - > -#endif > +MODULE_DESCRIPTION("Test code for ARM kprobes"); > +MODULE_LICENSE("GPL"); What happened with this cleanup patch? I don't see it on a mailing list or in linux.git or linux-next.git. I was about to come up with the same patch since it still seems to be needed in linux-next-20260430. thanks. -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro 2026-05-03 21:12 ` Randy Dunlap @ 2026-05-04 7:01 ` Arnd Bergmann 0 siblings, 0 replies; 6+ messages in thread From: Arnd Bergmann @ 2026-05-04 7:01 UTC (permalink / raw) To: Randy Dunlap, Jeff Johnson, Russell King Cc: linux-arm-kernel, linux-kernel, kernel-janitors On Sun, May 3, 2026, at 23:12, Randy Dunlap wrote: > On 7/19/24 4:28 AM, Arnd Bergmann wrote: >> On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote: >>> On 6/22/2024 9:34 PM, Jeff Johnson wrote: >> -#endif >> +MODULE_DESCRIPTION("Test code for ARM kprobes"); >> +MODULE_LICENSE("GPL"); > > What happened with this cleanup patch? > I don't see it on a mailing list or in linux.git or linux-next.git. > > I was about to come up with the same patch since it still seems to be > needed in linux-next-20260430. My mistake. I've sent it to the list now, will add it to the patch tracker when I get an Ack. Arnd ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-05-04 7:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-06-23 4:34 [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro Jeff Johnson 2024-07-09 19:53 ` Jeff Johnson 2024-07-19 11:28 ` Arnd Bergmann 2024-07-19 14:03 ` Jeff Johnson 2026-05-03 21:12 ` Randy Dunlap 2026-05-04 7:01 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox