From: fisaksen@baylibre.com (Frode Isaksen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/6] spi: davinci: do not use DMA for vmalloc'ed buffers
Date: Thu, 23 Feb 2017 19:02:00 +0100 [thread overview]
Message-ID: <1487872921-26628-6-git-send-email-fisaksen@baylibre.com> (raw)
In-Reply-To: <1487872921-26628-1-git-send-email-fisaksen@baylibre.com>
Using vmalloc'ed buffers will fail since daVinci has
VIVT cache and only the kernel lowmem virtual address
is invalidated/flushed when performing DMA.
The virtual address returned from vmalloc() is not
invalidated/flushed and may contain stale data when
returning from spi_sync().
Fixes errors when running UBIFS over SPI NOR.
Revert this when all upper layer users of vmalloc'ed
buffers sent to SPI handles cache flushing/invalidating.
Signed-off-by: Frode Isaksen <fisaksen@baylibre.com>
---
drivers/spi/spi-davinci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 75c658e..f37bbdd 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -482,7 +482,9 @@ static bool davinci_spi_can_dma(struct spi_master *master,
if (spicfg)
can_dma = (spicfg->io_type == SPI_IO_TYPE_DMA) &&
- (xfer->len >= DMA_MIN_BYTES);
+ (xfer->len >= DMA_MIN_BYTES) &&
+ !is_vmalloc_addr(xfer->rx_buf) &&
+ !is_vmalloc_addr(xfer->tx_buf);
return can_dma;
}
--
2.7.4
next prev parent reply other threads:[~2017-02-23 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 18:01 [PATCH v3 0/6] Enable DMA for daVinci SPI controller Frode Isaksen
2017-02-23 18:01 ` [PATCH v3 1/6] spi: davinci: Use SPI framework to handle DMA mapping Frode Isaksen
2017-03-07 14:22 ` Applied "spi: davinci: Use SPI framework to handle DMA mapping" to the spi tree Mark Brown
2017-02-23 18:01 ` [PATCH v3 2/6] spi: davinci: enable DMA when channels are defined in DT Frode Isaksen
2017-02-23 18:01 ` [PATCH v3 3/6] spi: davinci: use rx buffer as dummy tx buffer Frode Isaksen
2017-03-15 19:35 ` Mark Brown
2017-02-23 18:01 ` [PATCH v3 4/6] spi: davinci: do not use DMA if transfer length is less than 16 Frode Isaksen
2017-03-15 19:37 ` Applied "spi: davinci: do not use DMA if transfer length is less than 16" to the spi tree Mark Brown
2017-02-23 18:02 ` Frode Isaksen [this message]
2017-03-15 19:37 ` Applied "spi: davinci: do not use DMA for vmalloc'ed buffers" " Mark Brown
2017-02-23 18:02 ` [PATCH v3 6/6] spi: loopback-test: add option to use vmalloc'ed buffers Frode Isaksen
2017-03-16 14:11 ` Applied "spi: loopback-test: add option to use vmalloc'ed buffers" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487872921-26628-6-git-send-email-fisaksen@baylibre.com \
--to=fisaksen@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox