From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: Applied "spi: davinci: do not use DMA for vmalloc'ed buffers" to the spi tree
Date: Wed, 15 Mar 2017 19:37:11 +0000 [thread overview]
Message-ID: <E1coEjP-0004fu-Dt@debutante> (raw)
In-Reply-To: <1487872921-26628-6-git-send-email-fisaksen@baylibre.com>
The patch
spi: davinci: do not use DMA for vmalloc'ed buffers
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 4dd9becbce4f10009322c3e2297f9db3ace94a10 Mon Sep 17 00:00:00 2001
From: Frode Isaksen <fisaksen@baylibre.com>
Date: Thu, 23 Feb 2017 19:02:00 +0100
Subject: [PATCH] spi: davinci: do not use DMA for vmalloc'ed buffers
Using vmalloc'ed buffers will fail since daVinci has
VIVT cache and only the kernel lowmem virtual address
is invalidated/flushed when performing DMA.
The virtual address returned from vmalloc() is not
invalidated/flushed and may contain stale data when
returning from spi_sync().
Fixes errors when running UBIFS over SPI NOR.
Revert this when all upper layer users of vmalloc'ed
buffers sent to SPI handles cache flushing/invalidating.
Signed-off-by: Frode Isaksen <fisaksen@baylibre.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-davinci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 75c658e4e487..f37bbdd18d61 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -482,7 +482,9 @@ static bool davinci_spi_can_dma(struct spi_master *master,
if (spicfg)
can_dma = (spicfg->io_type == SPI_IO_TYPE_DMA) &&
- (xfer->len >= DMA_MIN_BYTES);
+ (xfer->len >= DMA_MIN_BYTES) &&
+ !is_vmalloc_addr(xfer->rx_buf) &&
+ !is_vmalloc_addr(xfer->tx_buf);
return can_dma;
}
--
2.11.0
next prev parent reply other threads:[~2017-03-15 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 18:01 [PATCH v3 0/6] Enable DMA for daVinci SPI controller Frode Isaksen
2017-02-23 18:01 ` [PATCH v3 1/6] spi: davinci: Use SPI framework to handle DMA mapping Frode Isaksen
2017-03-07 14:22 ` Applied "spi: davinci: Use SPI framework to handle DMA mapping" to the spi tree Mark Brown
2017-02-23 18:01 ` [PATCH v3 2/6] spi: davinci: enable DMA when channels are defined in DT Frode Isaksen
2017-02-23 18:01 ` [PATCH v3 3/6] spi: davinci: use rx buffer as dummy tx buffer Frode Isaksen
2017-03-15 19:35 ` Mark Brown
2017-02-23 18:01 ` [PATCH v3 4/6] spi: davinci: do not use DMA if transfer length is less than 16 Frode Isaksen
2017-03-15 19:37 ` Applied "spi: davinci: do not use DMA if transfer length is less than 16" to the spi tree Mark Brown
2017-02-23 18:02 ` [PATCH v3 5/6] spi: davinci: do not use DMA for vmalloc'ed buffers Frode Isaksen
2017-03-15 19:37 ` Mark Brown [this message]
2017-02-23 18:02 ` [PATCH v3 6/6] spi: loopback-test: add option to use " Frode Isaksen
2017-03-16 14:11 ` Applied "spi: loopback-test: add option to use vmalloc'ed buffers" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1coEjP-0004fu-Dt@debutante \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox