public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: barrier: Remove spec_bar() macro
Date: Thu, 25 Mar 2021 14:34:33 +0000	[thread overview]
Message-ID: <20210325143433.GA41100@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20210325141304.1607595-1-linus.walleij@linaro.org>

On Thu, Mar 25, 2021 at 03:13:04PM +0100, Linus Walleij wrote:
> The spec_bar() macro was introduced in
> commit bd4fb6d270bc ("arm64: Add support for SB barrier and patch in over DSB; ISB sequences")
> as a way for C to insert a speculation barrier and was then
> used in one single place: set_fs().
> 
> Later on
> commit 3d2403fd10a1 ("arm64: uaccess: remove set_fs()")
> deleted set_fs() altogether and as noted in the commit
> on the new path the regular sb() assembly macro will
> be used.
> 
> Delete the remnant.
> 
> Cc: Mark Rutland <mark.rutland@arm.com>
> Fixes: 3d2403fd10a1 ("arm64: uaccess: remove set_fs()")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

I think this is a cleanup rather than a fix, so we don't need the fixes
tag. I don't have a problem with this going, so with the fixes tag
removed:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/include/asm/barrier.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/barrier.h b/arch/arm64/include/asm/barrier.h
> index c3009b0e5239..bab29932d21b 100644
> --- a/arch/arm64/include/asm/barrier.h
> +++ b/arch/arm64/include/asm/barrier.h
> @@ -25,10 +25,6 @@
>  #define psb_csync()	asm volatile("hint #17" : : : "memory")
>  #define csdb()		asm volatile("hint #20" : : : "memory")
>  
> -#define spec_bar()	asm volatile(ALTERNATIVE("dsb nsh\nisb\n",		\
> -						 SB_BARRIER_INSN"nop\n",	\
> -						 ARM64_HAS_SB))
> -
>  #ifdef CONFIG_ARM64_PSEUDO_NMI
>  #define pmr_sync()						\
>  	do {							\
> -- 
> 2.29.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-25 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 14:13 [PATCH] arm64: barrier: Remove spec_bar() macro Linus Walleij
2021-03-25 14:34 ` Mark Rutland [this message]
2021-03-26 11:06 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210325143433.GA41100@C02TD0UTHF1T.local \
    --to=mark.rutland@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox