From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, Anshuman Khandual <anshuman.khandual@arm.com>
Subject: [PATCH V2 1/3] aarch64: Enable access into SCTLR2_ELx registers from EL2 and below
Date: Mon, 29 Jul 2024 10:06:04 +0530 [thread overview]
Message-ID: <20240729043606.871451-2-anshuman.khandual@arm.com> (raw)
In-Reply-To: <20240729043606.871451-1-anshuman.khandual@arm.com>
FEAT_SCTLR2 adds SCTLR2_EL1 and SCTLR2_EL2 system registers. But access
into these register from EL2 and below exception levels, will trap into EL3
unless SCR_EL3.SCTLR2En is set.
Enable access to SCTLR2_ELx registers when they are implemented. Given that
SCTLR2_ELx registers reset to UNKNOWN values - when the highest implemented
exception level is not ELx, this resets SCTLR2_ELx registers. Otherwise any
kernel which is not aware of these SCTLR2_ELx registers, will be subject to
arbitrary behaviour as a result of the SCTLR2_ELx bits which it will not
have configured.
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
arch/aarch64/include/asm/cpu.h | 7 ++++++-
arch/aarch64/init.c | 6 ++++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/aarch64/include/asm/cpu.h b/arch/aarch64/include/asm/cpu.h
index 846b89f..85e735b 100644
--- a/arch/aarch64/include/asm/cpu.h
+++ b/arch/aarch64/include/asm/cpu.h
@@ -20,6 +20,9 @@
#define TCR2_EL2 s3_4_c2_c0_3
#define TCR2_EL1 s3_0_c2_c0_3
+#define SCTLR2_EL1 s3_0_c1_c0_3
+#define SCTLR2_EL2 s3_4_c1_c0_3
+
/*
* RES1 bit definitions definitions as of ARM DDI 0487G.b
*
@@ -56,6 +59,7 @@
#define SCR_EL3_HXEn BIT(38)
#define SCR_EL3_EnTP2 BIT(41)
#define SCR_EL3_TCR2EN BIT(43)
+#define SCR_EL3_SCTLR2En BIT(44)
#define SCR_EL3_PIEN BIT(45)
#define HCR_EL2_RES1 BIT(1)
@@ -80,7 +84,8 @@
#define ID_AA64MMFR1_EL1_HCX BITS(43, 40)
-#define ID_AA64MMFR3_EL1_TCRX BITS(4, 0)
+#define ID_AA64MMFR3_EL1_TCRX BITS(3, 0)
+#define ID_AA64MMFR3_EL1_SCTLRX BITS(7, 4)
#define ID_AA64MMFR3_EL1_S1PIE BITS(11, 8)
#define ID_AA64MMFR3_EL1_S2PIE BITS(15, 12)
#define ID_AA64MMFR3_EL1_S1POE BITS(19, 16)
diff --git a/arch/aarch64/init.c b/arch/aarch64/init.c
index 37cb45f..fc0d2e3 100644
--- a/arch/aarch64/init.c
+++ b/arch/aarch64/init.c
@@ -89,6 +89,12 @@ void cpu_init_el3(void)
if (!kernel_is_32bit())
scr |= SCR_EL3_RW;
+ if (mrs_field(ID_AA64MMFR3_EL1, SCTLRX)) {
+ scr |= SCR_EL3_SCTLR2En;
+ msr(SCTLR2_EL2, 0);
+ msr(SCTLR2_EL1, 0);
+ }
+
msr(SCR_EL3, scr);
msr(CPTR_EL3, cptr);
--
2.25.1
next prev parent reply other threads:[~2024-07-29 4:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 4:36 [PATCH V2 0/3] aarch64: Enable access for FEAT_D128 registers in EL1/EL2 Anshuman Khandual
2024-07-29 4:36 ` Anshuman Khandual [this message]
2024-07-29 4:36 ` [PATCH V2 2/3] aarch64: Enable access into 128 bit system registers from EL2 and below Anshuman Khandual
2024-07-29 4:36 ` [PATCH V2 3/3] aarch64: Enable access into RCW[S]MASK_EL1 " Anshuman Khandual
2024-07-29 4:40 ` [PATCH V2 0/3] aarch64: Enable access for FEAT_D128 registers in EL1/EL2 Anshuman Khandual
2024-07-29 13:29 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729043606.871451-2-anshuman.khandual@arm.com \
--to=anshuman.khandual@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox