* [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
@ 2024-08-07 10:16 Bhavya Kapoor
2024-08-08 5:09 ` Manorit Chawdhry
2024-08-08 6:21 ` Neha Malcom Francis
0 siblings, 2 replies; 7+ messages in thread
From: Bhavya Kapoor @ 2024-08-07 10:16 UTC (permalink / raw)
To: linux-kernel, devicetree
Cc: linux-arm-kernel, conor+dt, krzk+dt, robh, kristo, b-kapoor,
m-chawdhry, vigneshr, nm, sinthu.raja, n-francis
mmc1 was not functional since pin mux for clklb was not present.
Thus, add clklb pin mux to get MMC working.
Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
rebased to next-20240807
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 90dbe31c5b81..d5ceab79536c 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
pinctrl-single,pins = <
J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
+ J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
2024-08-07 10:16 [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1 Bhavya Kapoor
@ 2024-08-08 5:09 ` Manorit Chawdhry
2024-08-08 6:21 ` Neha Malcom Francis
1 sibling, 0 replies; 7+ messages in thread
From: Manorit Chawdhry @ 2024-08-08 5:09 UTC (permalink / raw)
To: Bhavya Kapoor
Cc: linux-kernel, devicetree, linux-arm-kernel, conor+dt, krzk+dt,
robh, kristo, vigneshr, nm, sinthu.raja, n-francis
Hi Bhavya,
On 15:46-20240807, Bhavya Kapoor wrote:
> mmc1 was not functional since pin mux for clklb was not present.
> Thus, add clklb pin mux to get MMC working.
>
> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
>
> rebased to next-20240807
>
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 90dbe31c5b81..d5ceab79536c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
> pinctrl-single,pins = <
> J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
> J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
> + J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
> J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
> J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
> J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
Reviewed-by: Manorit Chawdhry <m-chawdhry@ti.com>
Regards,
Manorit
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
2024-08-07 10:16 [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1 Bhavya Kapoor
2024-08-08 5:09 ` Manorit Chawdhry
@ 2024-08-08 6:21 ` Neha Malcom Francis
2024-08-08 7:38 ` Bhavya Kapoor
1 sibling, 1 reply; 7+ messages in thread
From: Neha Malcom Francis @ 2024-08-08 6:21 UTC (permalink / raw)
To: Bhavya Kapoor, linux-kernel, devicetree
Cc: linux-arm-kernel, conor+dt, krzk+dt, robh, kristo, m-chawdhry,
vigneshr, nm, sinthu.raja
Hi Bhavya
On 07/08/24 15:46, Bhavya Kapoor wrote:
> mmc1 was not functional since pin mux for clklb was not present.
> Thus, add clklb pin mux to get MMC working.
>
> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
>
> rebased to next-20240807
>
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 90dbe31c5b81..d5ceab79536c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
> pinctrl-single,pins = <
> J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
> J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
> + J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
> J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
> J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
> J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
How is this different from the P23 pinmux for MMC1_CLK? Could you explain what
CLKLB is, since it doesn't have a ball number I'm finding it difficult to
understand what it is?
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
2024-08-08 6:21 ` Neha Malcom Francis
@ 2024-08-08 7:38 ` Bhavya Kapoor
2024-08-08 7:49 ` Neha Malcom Francis
0 siblings, 1 reply; 7+ messages in thread
From: Bhavya Kapoor @ 2024-08-08 7:38 UTC (permalink / raw)
To: Neha Malcom Francis, linux-kernel, devicetree
Cc: linux-arm-kernel, conor+dt, krzk+dt, robh, kristo, m-chawdhry,
vigneshr, nm, sinthu.raja
Hi Neha,
On 08/08/24 11:51 am, Neha Malcom Francis wrote:
> Hi Bhavya
>
> On 07/08/24 15:46, Bhavya Kapoor wrote:
>> mmc1 was not functional since pin mux for clklb was not present.
>> Thus, add clklb pin mux to get MMC working.
>>
>> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for
>> AM68 SK base board")
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
>>
>> rebased to next-20240807
>>
>> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>> b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>> index 90dbe31c5b81..d5ceab79536c 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>> @@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
>> pinctrl-single,pins = <
>> J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
>> J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
>> + J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
>> J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
>> J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
>> J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
>
> How is this different from the P23 pinmux for MMC1_CLK? Could you
> explain what CLKLB is, since it doesn't have a ball number I'm finding
> it difficult to understand what it is?
>
This pin needs to be setup so that MMC_CLK is looped back at pad level
for highspeed SDIO operations (has been same across K3 family). MMC0/1
has this pin configured as INPUT by reset default as these have boot media
These pinmuxes are derived from pinmux file shared by EVM team during
wakeup/board bringup.
Regards
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
2024-08-08 7:38 ` Bhavya Kapoor
@ 2024-08-08 7:49 ` Neha Malcom Francis
2024-08-08 8:29 ` Manorit Chawdhry
2024-08-08 10:53 ` Nishanth Menon
0 siblings, 2 replies; 7+ messages in thread
From: Neha Malcom Francis @ 2024-08-08 7:49 UTC (permalink / raw)
To: Bhavya Kapoor, linux-kernel, devicetree
Cc: linux-arm-kernel, conor+dt, krzk+dt, robh, kristo, m-chawdhry,
vigneshr, nm, sinthu.raja
Hi Bhavya
On 08/08/24 13:08, Bhavya Kapoor wrote:
> Hi Neha,
>
> On 08/08/24 11:51 am, Neha Malcom Francis wrote:
>> Hi Bhavya
>>
>> On 07/08/24 15:46, Bhavya Kapoor wrote:
>>> mmc1 was not functional since pin mux for clklb was not present.
>>> Thus, add clklb pin mux to get MMC working.
>>>
>>> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK
>>> base board")
>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>> ---
>>>
>>> rebased to next-20240807
>>>
>>> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>>> b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>>> index 90dbe31c5b81..d5ceab79536c 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
>>> @@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
>>> pinctrl-single,pins = <
>>> J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
>>> J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
>>> + J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
>>> J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
>>> J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
>>> J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
>>
>> How is this different from the P23 pinmux for MMC1_CLK? Could you explain what
>> CLKLB is, since it doesn't have a ball number I'm finding it difficult to
>> understand what it is?
>>
> This pin needs to be setup so that MMC_CLK is looped back at pad level for
> highspeed SDIO operations (has been same across K3 family). MMC0/1 has this pin
> configured as INPUT by reset default as these have boot media
>
> These pinmuxes are derived from pinmux file shared by EVM team during
> wakeup/board bringup.
>
Thank you for explaining.
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
> Regards
>
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
2024-08-08 7:49 ` Neha Malcom Francis
@ 2024-08-08 8:29 ` Manorit Chawdhry
2024-08-08 10:53 ` Nishanth Menon
1 sibling, 0 replies; 7+ messages in thread
From: Manorit Chawdhry @ 2024-08-08 8:29 UTC (permalink / raw)
To: Neha Malcom Francis
Cc: Bhavya Kapoor, linux-kernel, devicetree, linux-arm-kernel,
conor+dt, krzk+dt, robh, kristo, vigneshr, nm, sinthu.raja
Hi Bhavya,
On 13:19-20240808, Neha Malcom Francis wrote:
> Hi Bhavya
>
> On 08/08/24 13:08, Bhavya Kapoor wrote:
> > Hi Neha,
> >
> > On 08/08/24 11:51 am, Neha Malcom Francis wrote:
> > > Hi Bhavya
> > >
> > > On 07/08/24 15:46, Bhavya Kapoor wrote:
> > > > mmc1 was not functional since pin mux for clklb was not present.
> > > > Thus, add clklb pin mux to get MMC working.
> > > >
> > > > Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support
> > > > for AM68 SK base board")
> > > > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> > > > ---
> > > >
> > > > rebased to next-20240807
> > > >
> > > > arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > index 90dbe31c5b81..d5ceab79536c 100644
> > > > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > @@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
> > > > pinctrl-single,pins = <
> > > > J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
> > > > J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
> > > > + J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
> > > > J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
> > > > J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
> > > > J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
> > >
> > > How is this different from the P23 pinmux for MMC1_CLK? Could you
> > > explain what CLKLB is, since it doesn't have a ball number I'm
> > > finding it difficult to understand what it is?
> > >
> > This pin needs to be setup so that MMC_CLK is looped back at pad level
> > for highspeed SDIO operations (has been same across K3 family). MMC0/1
> > has this pin configured as INPUT by reset default as these have boot
> > media
> >
> > These pinmuxes are derived from pinmux file shared by EVM team during
> > wakeup/board bringup.
I think it'd be good to put this in the commit message as well for more
clarity.
Regards,
Manorit
> >
>
> Thank you for explaining.
>
> Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
>
> > Regards
> >
>
> --
> Thanking You
> Neha Malcom Francis
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1
2024-08-08 7:49 ` Neha Malcom Francis
2024-08-08 8:29 ` Manorit Chawdhry
@ 2024-08-08 10:53 ` Nishanth Menon
1 sibling, 0 replies; 7+ messages in thread
From: Nishanth Menon @ 2024-08-08 10:53 UTC (permalink / raw)
To: Neha Malcom Francis
Cc: Bhavya Kapoor, linux-kernel, devicetree, linux-arm-kernel,
conor+dt, krzk+dt, robh, kristo, m-chawdhry, vigneshr,
sinthu.raja
On 13:19-20240808, Neha Malcom Francis wrote:
> Hi Bhavya
>
> On 08/08/24 13:08, Bhavya Kapoor wrote:
> > Hi Neha,
> >
> > On 08/08/24 11:51 am, Neha Malcom Francis wrote:
> > > Hi Bhavya
> > >
> > > On 07/08/24 15:46, Bhavya Kapoor wrote:
> > > > mmc1 was not functional since pin mux for clklb was not present.
> > > > Thus, add clklb pin mux to get MMC working.
> > > >
> > > > Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support
> > > > for AM68 SK base board")
> > > > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> > > > ---
> > > >
> > > > rebased to next-20240807
> > > >
> > > > arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > index 90dbe31c5b81..d5ceab79536c 100644
> > > > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > > > @@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
> > > > pinctrl-single,pins = <
> > > > J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
> > > > J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
> > > > + J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
> > > > J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
> > > > J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
> > > > J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */
> > >
> > > How is this different from the P23 pinmux for MMC1_CLK? Could you
> > > explain what CLKLB is, since it doesn't have a ball number I'm
> > > finding it difficult to understand what it is?
> > >
> > This pin needs to be setup so that MMC_CLK is looped back at pad level
> > for highspeed SDIO operations (has been same across K3 family). MMC0/1
> > has this pin configured as INPUT by reset default as these have boot
> > media
> >
Please update the commit message with the explanation of what CLKLB pin
is. the "reset default" is a bit confusing description.
> > These pinmuxes are derived from pinmux file shared by EVM team during
> > wakeup/board bringup.
> >
>
> Thank you for explaining.
>
> Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-08 10:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-07 10:16 [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1 Bhavya Kapoor
2024-08-08 5:09 ` Manorit Chawdhry
2024-08-08 6:21 ` Neha Malcom Francis
2024-08-08 7:38 ` Bhavya Kapoor
2024-08-08 7:49 ` Neha Malcom Francis
2024-08-08 8:29 ` Manorit Chawdhry
2024-08-08 10:53 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox