From: Primoz Fiser <primoz.fiser@norik.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, upstream@lists.phytec.de
Subject: [PATCH 08/13] arm64: dts: freescale: imx93-phyboard-segin: Fix SD-card pinctrl
Date: Thu, 10 Apr 2025 11:02:46 +0200 [thread overview]
Message-ID: <20250410090251.1103979-9-primoz.fiser@norik.com> (raw)
In-Reply-To: <20250410090251.1103979-1-primoz.fiser@norik.com>
Until now, all usdhc2 (SD-card) pinctrl labels pointed to one pinctrl
group "usdhc2grp" which was overwritten twice by the 100 and 200 MHz
modes. Fix this by using unique pinctrl names.
While at it, apply i.MX93 chip errata ERR052021 workaround and adjust
pinctrl drive-strengths to improve signal integrity. Drive-strength
values come from the downstream PHYTEC kernel and were devised and
verified by the hardware department measurements.
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
.../dts/freescale/imx93-phyboard-segin.dts | 47 ++++++++++---------
1 file changed, 25 insertions(+), 22 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
index 3d5cd0561362..525f52789f8b 100644
--- a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
@@ -75,39 +75,42 @@ MX93_PAD_SD2_CD_B__GPIO3_IO00 0x31e
>;
};
+ /* need to config the SION for data and cmd pad, refer to ERR052021 */
pinctrl_usdhc2_default: usdhc2grp {
fsl,pins = <
- MX93_PAD_SD2_CLK__USDHC2_CLK 0x179e
- MX93_PAD_SD2_CMD__USDHC2_CMD 0x139e
- MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x138e
- MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x138e
- MX93_PAD_SD2_DATA2__USDHC2_DATA2 0x138e
- MX93_PAD_SD2_DATA3__USDHC2_DATA3 0x139e
+ MX93_PAD_SD2_CLK__USDHC2_CLK 0x159e
+ MX93_PAD_SD2_CMD__USDHC2_CMD 0x4000139e
+ MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x4000138e
+ MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x4000138e
+ MX93_PAD_SD2_DATA2__USDHC2_DATA2 0x4000138e
+ MX93_PAD_SD2_DATA3__USDHC2_DATA3 0x4000139e
MX93_PAD_SD2_VSELECT__USDHC2_VSELECT 0x51e
>;
};
- pinctrl_usdhc2_100mhz: usdhc2grp {
+ /* need to config the SION for data and cmd pad, refer to ERR052021 */
+ pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
fsl,pins = <
- MX93_PAD_SD2_CLK__USDHC2_CLK 0x179e
- MX93_PAD_SD2_CMD__USDHC2_CMD 0x139e
- MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x138e
- MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x138e
- MX93_PAD_SD2_DATA2__USDHC2_DATA2 0x139e
- MX93_PAD_SD2_DATA3__USDHC2_DATA3 0x139e
- MX93_PAD_SD2_VSELECT__USDHC2_VSELECT 0x51e
+ MX93_PAD_SD2_CLK__USDHC2_CLK 0x159e
+ MX93_PAD_SD2_CMD__USDHC2_CMD 0x4000139e
+ MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x4000138e
+ MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x4000138e
+ MX93_PAD_SD2_DATA2__USDHC2_DATA2 0x4000139e
+ MX93_PAD_SD2_DATA3__USDHC2_DATA3 0x4000139e
+ MX93_PAD_SD2_VSELECT__USDHC2_VSELECT 0x51e
>;
};
- pinctrl_usdhc2_200mhz: usdhc2grp {
+ /* need to config the SION for data and cmd pad, refer to ERR052021 */
+ pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
fsl,pins = <
- MX93_PAD_SD2_CLK__USDHC2_CLK 0x178e
- MX93_PAD_SD2_CMD__USDHC2_CMD 0x139e
- MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x139e
- MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x139e
- MX93_PAD_SD2_DATA2__USDHC2_DATA2 0x139e
- MX93_PAD_SD2_DATA3__USDHC2_DATA3 0x139e
- MX93_PAD_SD2_VSELECT__USDHC2_VSELECT 0x51e
+ MX93_PAD_SD2_CLK__USDHC2_CLK 0x158e
+ MX93_PAD_SD2_CMD__USDHC2_CMD 0x4000139e
+ MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x4000139e
+ MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x4000139e
+ MX93_PAD_SD2_DATA2__USDHC2_DATA2 0x4000139e
+ MX93_PAD_SD2_DATA3__USDHC2_DATA3 0x4000139e
+ MX93_PAD_SD2_VSELECT__USDHC2_VSELECT 0x51e
>;
};
};
--
2.34.1
next prev parent reply other threads:[~2025-04-10 11:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 9:02 [PATCH 00/13] Update PHYTEC i.MX93 DTS Primoz Fiser
2025-04-10 9:02 ` [PATCH 01/13] arm64: dts: freescale: imx93-phycore-som: Add PMIC support Primoz Fiser
2025-04-10 14:53 ` Frank Li
2025-04-10 9:02 ` [PATCH 02/13] arm64: dts: freescale: imx93-phycore-som: Add EEPROM support Primoz Fiser
2025-04-10 14:54 ` Frank Li
2025-04-10 9:02 ` [PATCH 03/13] arm64: dts: freescale: imx93-phycore-som: Disable LED pull-up Primoz Fiser
2025-04-10 14:49 ` Frank Li
2025-04-10 9:02 ` [PATCH 04/13] arm64: dts: freescale: imx93-phycore-som: Enhance eMMC pinctrl Primoz Fiser
2025-04-10 14:56 ` Frank Li
2025-04-11 6:29 ` Primoz Fiser
2025-04-11 14:34 ` Frank Li
2025-04-10 9:02 ` [PATCH 05/13] arm64: dts: freescale: imx93-phycore-som: Add eMMC no-1-8-v by default Primoz Fiser
2025-04-10 15:01 ` Frank Li
2025-04-11 6:51 ` Primoz Fiser
2025-04-11 14:32 ` Frank Li
2025-04-10 9:02 ` [PATCH 06/13] arm64: dts: freescale: imx93-phyboard-segin: Drop eMMC no-1-8-v flag Primoz Fiser
2025-04-10 15:02 ` Frank Li
2025-04-12 16:23 ` Stefan Wahren
2025-04-14 10:39 ` Primoz Fiser
2025-04-14 11:31 ` Stefan Wahren
2025-04-10 9:02 ` [PATCH 07/13] arm64: dts: freescale: imx93-phyboard-segin: Disable SD-card write-protect Primoz Fiser
2025-04-10 15:05 ` Frank Li
2025-04-10 9:02 ` Primoz Fiser [this message]
2025-04-10 15:08 ` [PATCH 08/13] arm64: dts: freescale: imx93-phyboard-segin: Fix SD-card pinctrl Frank Li
2025-04-10 9:02 ` [PATCH 09/13] arm64: dts: freescale: imx93-phyboard-segin: Add RTC support Primoz Fiser
2025-04-10 15:12 ` Frank Li
2025-04-11 7:51 ` Primoz Fiser
2025-04-10 9:02 ` [PATCH 10/13] arm64: dts: freescale: imx93-phyboard-segin: Add CAN support Primoz Fiser
2025-04-10 15:23 ` Frank Li
2025-04-11 8:08 ` Primoz Fiser
2025-04-11 14:30 ` Frank Li
2025-04-12 13:41 ` Marc Kleine-Budde
2025-04-14 8:02 ` Primoz Fiser
2025-04-10 9:02 ` [PATCH 11/13] arm64: dts: freescale: imx93-phyboard-segin: Add USB support Primoz Fiser
2025-04-10 15:25 ` Frank Li
2025-04-11 8:21 ` Ahmad Fatoum
2025-04-10 9:02 ` [PATCH 12/13] arm64: dts: freescale: imx93-phyboard-segin: Add I2S audio Primoz Fiser
2025-04-10 15:27 ` Frank Li
2025-04-10 9:02 ` [PATCH 13/13] arm64: dts: freescale: imx93-phyboard-segin: Add EQOS Ethernet Primoz Fiser
2025-04-10 15:30 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410090251.1103979-9-primoz.fiser@norik.com \
--to=primoz.fiser@norik.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox