From: Stefan Wahren <wahrenst@gmx.net>
To: Primoz Fiser <primoz.fiser@norik.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, upstream@lists.phytec.de
Subject: Re: [PATCH 06/13] arm64: dts: freescale: imx93-phyboard-segin: Drop eMMC no-1-8-v flag
Date: Mon, 14 Apr 2025 13:31:24 +0200 [thread overview]
Message-ID: <f49d9b14-cba9-4ded-a10d-ec6372ec66f8@gmx.net> (raw)
In-Reply-To: <ff6320e5-1c83-4cab-9cfe-4df6877952b8@norik.com>
Hi Primoz,
Am 14.04.25 um 12:39 schrieb Primoz Fiser:
> Hi Stefan,
>
> On 12. 04. 25 18:23, Stefan Wahren wrote:
>> Hi Primoz,
>>
>> Am 10.04.25 um 11:02 schrieb Primoz Fiser:
>>> Drop redundant 'no-1-8-v' flag from usdhc1 (eMMC) node. Flag is now set
>>> by default in the SOM include file (imx93-phycore-som.dtsi).
>>>
>>> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
>> i think, Patch 5 and this one should be squashed together.
> I intentionally split these series into SoM and board related patches.
>
> I see no benefit in squashing #5 and #6.
From my understanding both changes belong together, because you
actually moved the property from board to SoM level. Otherwise in case
there is something wrong later, both patches need to be reverted.
> Also, I already got Frank's Reviewed-by tag on this patch.
This wouldn't invalidate Frank's review.
Just my two cents
next prev parent reply other threads:[~2025-04-14 11:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 9:02 [PATCH 00/13] Update PHYTEC i.MX93 DTS Primoz Fiser
2025-04-10 9:02 ` [PATCH 01/13] arm64: dts: freescale: imx93-phycore-som: Add PMIC support Primoz Fiser
2025-04-10 14:53 ` Frank Li
2025-04-10 9:02 ` [PATCH 02/13] arm64: dts: freescale: imx93-phycore-som: Add EEPROM support Primoz Fiser
2025-04-10 14:54 ` Frank Li
2025-04-10 9:02 ` [PATCH 03/13] arm64: dts: freescale: imx93-phycore-som: Disable LED pull-up Primoz Fiser
2025-04-10 14:49 ` Frank Li
2025-04-10 9:02 ` [PATCH 04/13] arm64: dts: freescale: imx93-phycore-som: Enhance eMMC pinctrl Primoz Fiser
2025-04-10 14:56 ` Frank Li
2025-04-11 6:29 ` Primoz Fiser
2025-04-11 14:34 ` Frank Li
2025-04-10 9:02 ` [PATCH 05/13] arm64: dts: freescale: imx93-phycore-som: Add eMMC no-1-8-v by default Primoz Fiser
2025-04-10 15:01 ` Frank Li
2025-04-11 6:51 ` Primoz Fiser
2025-04-11 14:32 ` Frank Li
2025-04-10 9:02 ` [PATCH 06/13] arm64: dts: freescale: imx93-phyboard-segin: Drop eMMC no-1-8-v flag Primoz Fiser
2025-04-10 15:02 ` Frank Li
2025-04-12 16:23 ` Stefan Wahren
2025-04-14 10:39 ` Primoz Fiser
2025-04-14 11:31 ` Stefan Wahren [this message]
2025-04-10 9:02 ` [PATCH 07/13] arm64: dts: freescale: imx93-phyboard-segin: Disable SD-card write-protect Primoz Fiser
2025-04-10 15:05 ` Frank Li
2025-04-10 9:02 ` [PATCH 08/13] arm64: dts: freescale: imx93-phyboard-segin: Fix SD-card pinctrl Primoz Fiser
2025-04-10 15:08 ` Frank Li
2025-04-10 9:02 ` [PATCH 09/13] arm64: dts: freescale: imx93-phyboard-segin: Add RTC support Primoz Fiser
2025-04-10 15:12 ` Frank Li
2025-04-11 7:51 ` Primoz Fiser
2025-04-10 9:02 ` [PATCH 10/13] arm64: dts: freescale: imx93-phyboard-segin: Add CAN support Primoz Fiser
2025-04-10 15:23 ` Frank Li
2025-04-11 8:08 ` Primoz Fiser
2025-04-11 14:30 ` Frank Li
2025-04-12 13:41 ` Marc Kleine-Budde
2025-04-14 8:02 ` Primoz Fiser
2025-04-10 9:02 ` [PATCH 11/13] arm64: dts: freescale: imx93-phyboard-segin: Add USB support Primoz Fiser
2025-04-10 15:25 ` Frank Li
2025-04-11 8:21 ` Ahmad Fatoum
2025-04-10 9:02 ` [PATCH 12/13] arm64: dts: freescale: imx93-phyboard-segin: Add I2S audio Primoz Fiser
2025-04-10 15:27 ` Frank Li
2025-04-10 9:02 ` [PATCH 13/13] arm64: dts: freescale: imx93-phyboard-segin: Add EQOS Ethernet Primoz Fiser
2025-04-10 15:30 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f49d9b14-cba9-4ded-a10d-ec6372ec66f8@gmx.net \
--to=wahrenst@gmx.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox