Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
	linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Demi Marie Obenour <demiobenour@gmail.com>,
	Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH] crypto: qce - Remove driver
Date: Fri, 24 Jul 2026 17:25:46 +0200	[thread overview]
Message-ID: <2026072428-ungodly-outsource-b20c@gregkh> (raw)
In-Reply-To: <20260724150932.GA6763@sol>

On Fri, Jul 24, 2026 at 08:09:32AM -0700, Eric Biggers wrote:
> On Fri, Jul 24, 2026 at 05:04:46PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Jul 24, 2026 at 02:47:48PM +0000, Bartosz Golaszewski wrote:
> > > On Fri, 24 Jul 2026 16:14:14 +0200, Eric Biggers <ebiggers@kernel.org> said:
> > > >
> > > > And with the defaults QCE is *never* used.
> > > >
> > > 
> > > It's almost EOD here and I'm going to disconnect for the weekend but I just
> > > wanted to say before I leave: this has never been a reason for an aggresive
> > > removal of any driver. We remove drivers when we stop supporting entire
> > > platforms, not mostly unused drivers on actively *supported* platforms where
> > > they can still be used for experimentation and testing. I'm fine with dropping
> > > this from arm64 defconfig but with fixes, the BROKEN tag should be removed
> > > and I definitely object to removing it from the tree. How many people still
> > > use greybus? Should we drop it from the kernel too? And I'm saying it as
> > > a project ARA alumni. :)
> > 
> > I agree, if someone is willing to maintain it, and there are actual
> > in-kernel uses of it (meaning not just a stand-alone library that can
> > never be called either by userspace or hardware), it should stay.
> 
> What would we be considering the in-kernel uses to be, then?  Just
> wiring it up to the framework is enough, regardless of actual use?

I was meaning that we just don't want to have code lying around that is
impossible to use.

I'll defer to the subsystem maintainer if they want to remove it or not
here, as that's their call, not mine.

But really, if someone wants to maintain it, no matter how slow it might
be, I don't see the harm in keeping it if it's not causing any other
problems.

thanks,

greg k-h


  reply	other threads:[~2026-07-24 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260724050645.223799-1-ebiggers@kernel.org>
2026-07-24  5:28 ` [PATCH] crypto: qce - Remove driver Greg Kroah-Hartman
2026-07-24  7:36   ` Bartosz Golaszewski
2026-07-24  8:41     ` Greg Kroah-Hartman
2026-07-24  9:29       ` Bartosz Golaszewski
2026-07-24 14:14         ` Eric Biggers
2026-07-24 14:47           ` Bartosz Golaszewski
2026-07-24 15:04             ` Greg Kroah-Hartman
2026-07-24 15:09               ` Eric Biggers
2026-07-24 15:25                 ` Greg Kroah-Hartman [this message]
2026-07-24 15:51                   ` Eric Biggers
     [not found] ` <amM22cX7KTqyOoOk@sumit-xelite>
2026-07-24 13:51   ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026072428-ungodly-outsource-b20c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=brgl@kernel.org \
    --cc=demiobenour@gmail.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox